Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testgrid/release: replace kubeadm-gce* jobs with kubeadm-kind(er)* #12493

Merged
merged 1 commit into from
May 7, 2019

Conversation

neolit123
Copy link
Member

@neolit123 neolit123 commented May 6, 2019

The kubeadm-gce* jobs are no longer supported due to the
underlying deployer - kubernetes-anywhere being long deprecated.
SIG Cluster Lifecycle spent a lot of effort this cycle
implementing a solution for testing kubeadm upgrade and skew
scenarios.

This resulted in a tool kinder, which is based on the
kind backend but with a few more commands to support
upgrade and skew.

This PR does the following in release-x-all/informing dashboards:

  • replace kubeadm-gce-x with kubeadm-kind-x
  • replace kubeadm-gce-x-on-y with kubeadm-kinder-y-on-x *
  • replace kubeadm-gce-upgrade-x-y with kubeadm-kinder-upgrade-x-y

* y-on-x or (x+1)-on-(x) is more correct, because we are creating a x cluster using kubeadmx+1.

/assign @spiffxp
cc @fabriziopandini @mariantalla @alejandrox1
/sig cluster-lifecycle
/sig release
/priority important-longterm
/kind cleanup

possibly we can close the following ticket using this PR:
fixes kubernetes/sig-release#518

@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/release Categorizes an issue or PR as relevant to SIG Release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/testgrid sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels May 6, 2019
@k8s-ci-robot k8s-ci-robot requested review from shyamjvs and spiffxp May 6, 2019 23:34
@spiffxp
Copy link
Member

spiffxp commented May 6, 2019

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ab44c043753c7c3b8e55eabae3e16ce2e1c72d98

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2019
The kubeadm-gce* jobs are no longer supported due to the
underlying deployer - kubernetes-anywhere.
SIG Cluster Lifecycle spent a lot of effort this cycle
implementing a solution for testing kubeadm upgrade and skew
scenarios.

This resulted in a tool called kinder, which is based on the
kind backend but with a few more commands to support
upgrade and skew.

This PR does the following in release-x-all/informing dashboards:
- replace kubeadm-gce-x with kubeadm-kind-x
- replace kubeadm-gce-x-on-y with kubeadm-kinder-y-on-x
- replace kubeadm-gce-upgrade-x-y with kubeadm-kinder-upgrade-x-y
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2019
@spiffxp
Copy link
Member

spiffxp commented May 7, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 7, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d3bf77b673585ed04db80416b932af4a0d7c3a97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQUEST] remove kubeadm-gce* tests from release blocking
3 participants