Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build break - Deal better with wild cards #800

Merged
merged 1 commit into from
Jul 2, 2019
Merged

Fix build break - Deal better with wild cards #800

merged 1 commit into from
Jul 2, 2019

Conversation

dims
Copy link
Member

@dims dims commented Jul 2, 2019

Fix problem in latest logs - https://prow.k8s.io/view/gcs/kubernetes-jenkins/logs/ci-kubernetes-build/1146138862850936833/

I0702 20:29:33.385] - Copying artifacts to gs://kubernetes-release-dev/ci/v1.16.0-alpha.0.1799+4a1f71076bcaec: 
I0702 20:29:33.385] push-build.sh::release::gcs::push_release_artifacts(): /google-cloud-sdk/bin/gsutil -qm cp -rc /go/src/k8s.io/kubernetes/_output/gcs-stage/v1.16.0-alpha.0.1799+4a1f71076bcaec/* gs://kubernetes-release-dev/ci/v1.16.0-alpha.0.1799+4a1f71076bcaec/
W0702 20:29:33.486] tar: *: Cannot stat: No such file or directory
W0702 20:29:33.486] tar: Exiting with failure status due to previous errors
W0702 20:29:33.486] tar: /go/src/k8s.io/kubernetes/_output/release-stage/client/-- darwin-386 darwin-amd64 linux-386 linux-amd64 linux-arm linux-arm64 linux-ppc64le linux-s390x windows-386 windows-amd64/kubernetes/client/bin: Cannot open: No such file or directory
W0702 20:29:33.487] tar: Error is not recoverable: exiting now
W0702 20:29:33.487] tar: This does not look like a tar archive
W0702 20:29:33.487] tar: Exiting with failure status due to previous errors
I0702 20:29:35.043] OK

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 2, 2019
@dims
Copy link
Member Author

dims commented Jul 2, 2019

/assign @cblecker @BenTheElder

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 2, 2019
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Jul 2, 2019
@dims
Copy link
Member Author

dims commented Jul 2, 2019

/assign @spiffxp @justaugustus

BenTheElder
BenTheElder reviewed Jul 2, 2019
View reviewed changes
lib/releaselib.sh
@@ -575,7 +575,7 @@ release::gcs::push_release_artifacts() {
# We explicitly don't set an ACL in the cp call, since doing so will override
# any default bucket ACLs.
logecho -n "- Copying artifacts to $dest: "
logrun -s "$GSUTIL" -qm cp -rc "$src/*" "$dest/" || return 1
logrun -s "$GSUTIL" -qm cp -rc "$src"/* "$dest/" || return 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: we should use brace expansion

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe:

Suggested change
logrun -s "$GSUTIL" -qm cp -rc "$src"/* "$dest/" || return 1
logrun -s "$GSUTIL" -qm cp -rc "${src}/"* "$dest/" || return 1

?

@pswica
Copy link
Contributor

pswica commented Jul 2, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 2, 2019
@pswica pswica mentioned this pull request Jul 2, 2019
Closed
BenTheElder
BenTheElder approved these changes Jul 2, 2019
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
LGTM for correctness fix, style nits can come later

@hoegaarden
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, dims, hoegaarden, pswica

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2019
@k8s-ci-robot k8s-ci-robot merged commit 3866393 into kubernetes:master Jul 2, 2019
@dims dims mentioned this pull request Jul 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder approved these changes

@claurence claurence Awaiting requested review from claurence

@idealhack idealhack Awaiting requested review from idealhack

Assignees

@spiffxp spiffxp

@justaugustus justaugustus

@BenTheElder BenTheElder

@hoegaarden hoegaarden

@cblecker cblecker

@pswica pswica

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@dims @pswica @hoegaarden @k8s-ci-robot @BenTheElder @spiffxp @justaugustus @cblecker