Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shellcheck Post-Merge Issues/Concerns #786

Closed
pswica opened this issue Jul 2, 2019 · 8 comments
Closed

Shellcheck Post-Merge Issues/Concerns #786

pswica opened this issue Jul 2, 2019 · 8 comments
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release.

Comments

@pswica
Copy link
Contributor

pswica commented Jul 2, 2019

I am making a generic issue here for myself, and others, to catch any potential weirdness/bugs introduced after I cleaned our scripts with shellcheck
@pswica
Copy link
Contributor Author

pswica commented Jul 2, 2019 •
edited
Loading

@spiffxp found some likely changes that need to be made in his comments here: #763

@pswica
Copy link
Contributor Author

pswica commented Jul 2, 2019

@spiffxp found these likely changes #765 (review)

@pswica pswica mentioned this issue Jul 2, 2019
Merged
@pswica
Copy link
Contributor Author

pswica commented Jul 2, 2019

#765 (comment)

@listx Found a typo/bug caused by Mapfiles

@pswica pswica mentioned this issue Jul 2, 2019
Merged
@pswica
Copy link
Contributor Author

pswica commented Jul 2, 2019

#797

This was a big one. test-infra uses push-build.sh, which relies on our lib/releaselib.sh, among others.

@pswica
Copy link
Contributor Author

pswica commented Jul 2, 2019

#800

@pswica
Copy link
Contributor Author

pswica commented Jul 3, 2019

#802

@pswica
Copy link
Contributor Author

pswica commented Jul 8, 2019

/close

@k8s-ci-robot
Copy link
Contributor

@pswica: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@justaugustus justaugustus added sig/release Categorizes an issue or PR as relevant to SIG Release. area/release-eng Issues or PRs related to the Release Engineering subproject labels Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@justaugustus @pswica @k8s-ci-robot