Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path for kubelet.env file in kubelet deb package #3625

Merged
merged 1 commit into from
May 28, 2024

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented May 28, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

We received two reports that our kubelet Debian package installs kubelet.env file in a wrong location:

I was able to confirm these reports. As per some guidelines:

  • /etc/default should be used on Debian-based operating systems
  • /etc/sysconfig should be used on RPM-based operating systems

We partially fixed the issue a while ago with #3279, by ensuring that kubeadm is going to read the file from the correct path, but we didn't ensure that we install the file in the correct location. This is now fixed with this PR.

I tried building and installing the package locally to make sure the file is created in the correct location. This change will be applied to all kubelet packages that we build (for all minor releases) once this PR is merged. I don't expect this to regress in any way. 🤞

Does this PR introduce a user-facing change?

`kubelet.env` file is now installed in `/etc/default` instead of `/etc/sysconfig` on Debian-based systems by the `kubelet` package

/assign @saschagrunert @cpanato @puerco
cc @kubernetes/release-engineering

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 28, 2024
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority area/release-eng Issues or PRs related to the Release Engineering subproject labels May 28, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 28, 2024
@xmudrii xmudrii changed the title Fix path for kubelet.env file in deb package Fix path for kubelet.env file in kubelet deb package May 28, 2024
@xmudrii
Copy link
Member Author

xmudrii commented May 28, 2024

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority labels May 28, 2024
@xmudrii
Copy link
Member Author

xmudrii commented May 28, 2024

$ dpkg -L kubelet | grep /kubelet
/etc/default/kubelet
/lib/systemd/system/kubelet.service
/usr/bin/kubelet
/usr/share/doc/kubelet
/usr/share/doc/kubelet/LICENSE
/usr/share/doc/kubelet/README.md
/var/lib/kubelet
/var/lib/kubelet/.kubelet-keep

Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, but the release note has a typo deafult

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2024
@xmudrii
Copy link
Member Author

xmudrii commented May 28, 2024

@saschagrunert Good point, fixed! 😅

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, saschagrunert, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8b34633 into kubernetes:master May 28, 2024
11 checks passed
@xmudrii xmudrii deleted the fix-kubelet-extra-path branch May 28, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants