-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix EnvironmentFile path for kubeadm deb package #3279
Conversation
Signed-off-by: Marko Mudrinić <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @kubernetes/kubeadm-maintainers |
@pacoxu: GitHub didn't allow me to request PR reviews from the following users: kubernetes/kubeadm-maintainers. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is half of the fix, the package places the defaults file in the RedHat location: $ dpkg -L kubelet |grep /kubelet So this was halfway fixed, you're referring to an env file that doesn't exist. So the 2nd part of the fix is to adjust the file path in the package. |
What type of PR is this?
/kind bug
/kind regression
What this PR does / why we need it:
Debian packages published to the legacy repos have EnvironmentFile in
10-kubeadm.conf
set to/etc/default/kubelet
. However, Debian packages published topkgs.k8s.io
have this variable set to/etc/sysconfig/kubelet
This is wrong as described in #3276 and https://kubernetes.slack.com/archives/C09NXKJKA/p1694790202990129
Moreover, this is breaking some clusters as described in #3219 (comment)
This PR is supposed to fix this issue by applying some
sed
magic when building packages ✨ 🧙Which issue(s) this PR fixes:
Fixes #3276
Special notes for your reviewer:
I'll properly test this change after the PR is merged because I can't run a nomock job on a non-master branch. This fix only applies on packages published after the fix is merged, we don't have a way to alter existing packages.
/priority critical-urgent
Does this PR introduce a user-facing change?
/assign @saschagrunert
cc @kubernetes/release-engineering