Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove krel changelog docs #2591

Merged
merged 1 commit into from
Jun 30, 2022
Merged

Remove krel changelog docs #2591

merged 1 commit into from
Jun 30, 2022

Conversation

ramrodo
Copy link
Member

@ramrodo ramrodo commented Jun 29, 2022

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR removes the krel changelog documentation since this subcommand no longer exists. It was removed on #2401

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 29, 2022
@k8s-ci-robot k8s-ci-robot requested a review from mkorbi June 29, 2022 20:27
@k8s-ci-robot k8s-ci-robot added the area/release-eng Issues or PRs related to the Release Engineering subproject label Jun 29, 2022
@k8s-ci-robot k8s-ci-robot added the sig/release Categorizes an issue or PR as relevant to SIG Release. label Jun 29, 2022
wilsonehusin
wilsonehusin approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@wilsonehusin wilsonehusin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 29, 2022
@ramrodo
Copy link
Member Author

ramrodo commented Jun 29, 2022

/assign @saschagrunert

@orsenthil
Copy link
Member

/lgtm

saschagrunert
saschagrunert approved these changes Jun 30, 2022
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ramrodo, saschagrunert, wilsonehusin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2022
@k8s-ci-robot k8s-ci-robot merged commit 9d5d0aa into kubernetes:master Jun 30, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 30, 2022
@csantanapr
Copy link
Member

thanks
/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilsonehusin wilsonehusin wilsonehusin approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

@mkorbi mkorbi Awaiting requested review from mkorbi

@sethmccombs sethmccombs Awaiting requested review from sethmccombs

Assignees

@orsenthil orsenthil

@saschagrunert saschagrunert

@wilsonehusin wilsonehusin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.
6 participants
@ramrodo @orsenthil @k8s-ci-robot @csantanapr @saschagrunert @wilsonehusin