Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove krel changelog #2401

Merged
merged 1 commit into from
Jan 21, 2022
Merged

Remove krel changelog #2401

merged 1 commit into from
Jan 21, 2022

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind api-change
/kind deprecation

What this PR does / why we need it:

This subcommand has no use nowadays so therefore we remove it. We still
keep the integration tests for the pkg/changelog package.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Removed `krel changelog` subcommand.

@saschagrunert
Remove krel changelog
37b8e4e 
This subcommand has no use nowadays so therefore we remove it. We still
keep the integration tests for the `pkg/changelog` package.

Signed-off-by: Sascha Grunert <[email protected]>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 21, 2022
cpanato
cpanato approved these changes Jan 21, 2022
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for keeping clean
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 21, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cpanato,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saschagrunert
Copy link
Member Author 

Hit the rate limit on try 1, sleeping for 48m0.105469402s" err="GET https://api.github.com/repos/kubernetes/kubernetes/tags?page=7&per_page=50: 403 API rate limit of 60 still exceeded until 2022-01-21 11:46:29 +0000 UTC, not making remote request. [rate reset in 48m00s]"

@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@saschagrunert
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 493ac96 into kubernetes:master Jan 21, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Jan 21, 2022
@saschagrunert saschagrunert deleted the changelog-cli branch January 21, 2022 13:23
@ramrodo ramrodo mentioned this pull request Jun 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@sethmccombs sethmccombs Awaiting requested review from sethmccombs

@thejoycekung thejoycekung Awaiting requested review from thejoycekung

Assignees

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.
4 participants
@saschagrunert @k8s-ci-robot @k8s-triage-robot @cpanato