Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Signal reporter uses new CI Signal beta project board #2454

Merged

Conversation

leonardpahlke
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

CI Signal Reporter CLI uses the new CI Signal Project board now.
The [old CI Signal Project board](new CI Signal Project board) does not get maintained anymore.

I added a new dependency: shurcooL/githubv4 to interact with the GitHub GraphQL API. I could not find a REST API to access beta project boards (see Using the API to manage projects (Beta)).

Which issue(s) this PR fixes:

Fixes #2396

Special notes for your reviewer:

There are two other related Issues open that will follow after this one.

Does this PR introduce a user-facing change?

The CI Signal Report CLI now uses the new Project board to generate the GitHub part of the report https://github.com/orgs/kubernetes/projects/68

cc @kubernetes/ci-signal

/label tide/merge-method-squash
/assign @puerco

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 5, 2022
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Mar 5, 2022
@leonardpahlke
Copy link
Member Author

leonardpahlke commented Mar 7, 2022

Not sure about this: pull-release-test — Pod timeout. Maybe flake?
/retest

cc @saschagrunert

@leonardpahlke
Copy link
Member Author

Test passed now

Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two nits, otherwise LGTM

cmd/ci-reporter/cmd/github.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leonardpahlke, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2022
@k8s-ci-robot k8s-ci-robot merged commit 3af8887 into kubernetes:master Mar 7, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci-signal-reporter, use new ci signal github project board
4 participants