Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubecross: remove Makefile.build-image dependencie and check if the env vars are set #1944

Merged
merged 1 commit into from
Mar 12, 2021
Merged

kubecross: remove Makefile.build-image dependencie and check if the env vars are set #1944

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions images/build/cross/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,6 @@
# See the License for the specific language governing permissions and
# limitations under the License.

# include the common image-building Makefiles
include $(CURDIR)/../Makefile.build-image

# set default shell
SHELL=/bin/bash -o pipefail

Expand Down Expand Up @@ -46,10 +43,15 @@ endif

ARCHS = $(patsubst linux/%,%,$(PLATFORMS))

check-env:
ifndef REGISTRY
$(error REGISTRY is undefined, please set to registry you want to push)
endif

# build with buildx
# https://github.com/docker/buildx/issues/59
.PHONY: container
container: init-docker-buildx
container: check-env init-docker-buildx
echo "Building $(IMGNAME) for the following platforms: $(PLATFORMS)"
@for platform in $(PLATFORMS); do \
echo "Starting build for $${platform} platform"; \
Expand Down