Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubecross: remove Makefile.build-image dependencie and check if the env vars are set #1944

Merged
merged 1 commit into from
Mar 12, 2021

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Mar 11, 2021

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Follow up for #1943

remove the Makefile.build-image script dependency and perform environment check.
For now, it checks if the REGISTRY is set

/assign @justaugustus @saschagrunert @hasheddan

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Mar 11, 2021
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Mar 11, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 11, 2021
@cpanato
Copy link
Member Author

cpanato commented Mar 11, 2021

examples:

$ make container
Makefile:48: *** REGISTRY is undefined, please set to registry you want to push.  Stop.

and

$ REGISTRY=test/honk make container
./../../../hack/init-buildx.sh
echo "Building kube-cross for the following platforms: linux/amd64 linux/arm64 linux/ppc64le "
Building kube-cross for the following platforms: linux/amd64 linux/arm64 linux/ppc64le
Starting build for linux/amd64 platform
#1 [internal] load build definition from Dockerfile
#1 sha256:9f2685b62d868cedf4dd8f1c397bd7344b11d01ec8c9766053d135a0ff3d9c61
#1 transferring dockerfile: 32B done
#1 DONE 0.0s

#2 [internal] load .dockerignore
#2 sha256:5cda1b93467aa46a9900e409663e48d24445c333a6e32668cd00ae747d875646
#2 transferring context: 2B done
#2 DONE 0.0s

@cpanato cpanato added this to the v1.21 milestone Mar 11, 2021
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, hasheddan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5c0c51d into kubernetes:master Mar 12, 2021
@cpanato cpanato deleted the remove_hardcoded branch March 12, 2021 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants