Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REQUEST: Netlify site for node-feature-discovery #3665

Closed
fmuyassarov opened this issue Sep 7, 2022 · 15 comments
Closed

REQUEST: Netlify site for node-feature-discovery #3665

fmuyassarov opened this issue Sep 7, 2022 · 15 comments
Assignees
Labels
area/github-integration Third-party integrations, webhooks, or GitHub Apps

Comments

@fmuyassarov
Copy link
Member

Repository

kubernetes-sigs/node-feature-discovery

Project domain

nfd.sigs.k8s.io

Additional context for request

No response

@fmuyassarov fmuyassarov added the area/github-integration Third-party integrations, webhooks, or GitHub Apps label Sep 7, 2022
@fmuyassarov
Copy link
Member Author

/cc @marquiz

@fmuyassarov
Copy link
Member Author

/cc @ArangoGutierrez

@fmuyassarov
Copy link
Member Author

/cc @mrbobbytables

@mrbobbytables
Copy link
Member

I can get it going, but you'll want to stub out a netlify.toml file and open a PR to k/k8s.io to add the dns entry. If I enable netlify before its ready to be configured in repo it'll report as a failing test on all PRs.

@fmuyassarov
Copy link
Member Author

good point, thanks @mrbobbytables . I will come back once we are done with your suggestions.
/hold

@fmuyassarov
Copy link
Member Author

Hi @mrbobbytables . We have added the netlify.toml to the repo and we actually don't need a DNS entry because we are not planning to use Netlify to host our docs, but use it as for the preview tool for now. As such, we only need to add a new site based on the github repo, which I can do myself already because I'm already a member of "CNCF projects" team on Netlify. So, there is no more actions required to be done from your side. Thank you.

@fmuyassarov
Copy link
Member Author

fmuyassarov commented Sep 27, 2022

Actually I just realized that I don't have enough permissions to configure the Netlify on node-feature-discovery repository. @mrbobbytables Can you perhaps help here to add a new site for us? We only need it for master branch for now.

Screenshot from 2022-09-27 11-12-38

@fmuyassarov
Copy link
Member Author

@mrbobbytables Would you recommend to obtain admins rights on the repo or can we ask someone with admin rights to help us here ?

@mrbobbytables
Copy link
Member

One of us as github admins sets it up 👍
I was traveling last week, will enable it now.

@mrbobbytables
Copy link
Member

Site is live at: https://kubernetes-sigs-nfd.netlify.app/
I couldn't use kubernetes-sigs-node-feature-discovery for the site name, url was too long

If you want the domain nfd.sigs.k8s.io it'll require a bit more configuration after a PR is made to k/k8s.io to add the url.

@fmuyassarov
Copy link
Member Author

Awesome, thank you. The name is fine for now.

@mrbobbytables
Copy link
Member

Cool - do you want to leave this open till the name is sorted out? or close and follow up later?

@fmuyassarov
Copy link
Member Author

Let's close it for now since our original request is completed.
Thanks again.
/close

@k8s-ci-robot
Copy link
Contributor

@fmuyassarov: Closing this issue.

In response to this:

Let's close it for now since our original request is completed.
Thanks again.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@marquiz
Copy link
Contributor

marquiz commented Oct 3, 2022

Wow, really cool 😎 Thanks again @fmuyassarov and @mrbobbytables for working on this1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/github-integration Third-party integrations, webhooks, or GitHub Apps
Projects
None yet
Development

No branches or pull requests

4 participants