-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Netlify configuration file #895
Add Netlify configuration file #895
Conversation
This patch adds netlify configuration file which includes steps needed to build the documentation as part of presubmit review process. Signed-off-by: Feruzjon Muyassarov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fmuyassarov! Looks simple enough to me. Haven't verified this myself but I trust you 😊
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fmuyassarov, marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks, actually I forgot to mention that I have done prior test based on the config and example of deployed build is available here: https://632439999eada305e60df2e4--cozy-malabi-ecd098.netlify.app/get-started/index.html |
/cc @ArangoGutierrez |
/cc @zvonkok |
/lgtm |
This patch adds netlify configuration file which includes steps needed to build
the documentation as part of presubmit review process. I was planning to add
these commands from the web UI, but it is better to keep it here transparency
and the version control purposes.
Prerequisite for #886 and kubernetes/org#3665