-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
machine: add parallels support #953
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA. Once you've signed, please reply here (e.g. "I signed it!") and we'll verify. Thanks.
If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Can one of the admins verify this patch? |
1 similar comment
Can one of the admins verify this patch? |
Current coverage is 34.81% (diff: 0.00%)@@ master #953 diff @@
==========================================
Files 43 43
Lines 1978 1982 +4
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 690 690
- Misses 1152 1156 +4
Partials 136 136
|
I signed it! |
@minikube-bot test this please |
@minikube-bot ok to test |
Thanks for the PR. We're trying to keep our test matrix low by only supporting a few virtualization systems per platform, but we have had quite a few requests for parallels. Would you mind explaining the benefits of parallels over xhyve? That's where we've been spending most of our time. |
I agree with @denji 's points and assessment of the advantages, and would definitely support inclusion of a parallels provider. |
I would definitely support inclusion of a parallels provider, too. And why this pr not proceed to deal with? |
Any news on this one? Parallels is supported and works very well on Docker-Machine, why shouldn't you include it? |
Bringing this up with +1.
I'm not quite aware of any benefits, but you – team Minikube – shall consider one: if someone is already using Parallels for their needs, why one should install another vm if supporting Parallels is so simple according to this PR's commit diff? |
It looks like the XHYVE driver overrides the Docker for Mac docker-machine, so if you also still want to use the Docker provided version you may have some hoops to jump through in that regard. With how small of a change it is to support it, is it that bad of a trade off? |
+1, Parallels is a performant and supported virtualization platform on Mac. xhyve doesn't seem nearly as stable as Docker's implementation of hypervisor.framework. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle rotten |
I'm another person that would really like to see parallels support added into minikube. |
+1 for parallels support. If the issue is keeping the test matrix small, then merge this PR and mark parallels support |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle rotten |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
mind addressing the merge conflicts? I'd like to see about getting this included as an experimental driver (meaning: not initially covered by our CI) |
@denji This PR needs rebase. Also Please look at the failing tests. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: denji If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thank you for your contribution! |
Fix parallels support after #953
xhyve will not work on older iMac, CPU core the presence of support VT-d will not help. Paralells works along with VMware Fusion.
Hypervisor.framework
.Hypervisor.framework
will not working VT-x without (EPT & Unrestricted Mode)