Add support for parallels on macOS

[bassam]

This is a continuation of the work started in #953. Parallels is a leading virtualization solution on macOS and its only natural that minikube supports along side virtualbox and VMware fusion.

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bassam
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: dlorenc

Assign the PR to them by writing /assign @dlorenc in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[minikube-bot]

Can one of the admins verify this patch?

[bassam]

@minikube-bot retest this please

[gbraad]

@r2d4 @dlorenc Do we want to continue adding drivers to Minikube, or have them being proposed at machine-drivers org instead? https://github.com/machine-drivers

[bassam]

@r2d4 @dlorenc anything else needed for this PR?

[dlorenc]

@r2d4 @dlorenc Do we want to continue adding drivers to Minikube, or have
them being proposed at machine-drivers org instead?
https://github.com/machine-drivers

Yes, we should add any other drivers to the docker-machine-drivers organization rather than adding them here. We'll also need a way to run integration tests on any new drivers before we can formally document support for them.

[dlorenc]

I'll close this PR here, @bassam let us know if you need assistance in getting the driver moved to the proper organization.

[bassam]

@dlorenc I'm not sure I follow. https://github.com/Parallels/docker-machine-parallels is a docker-machine driver, why does not need to be part of machine-drivers org?

how would you suggest that I add integration tests for this? Does minikube test on macos?

[gbraad]

You proposed the driver to the minikube oganization. Minikube and Minishift do not add drivers to their repositories. This is why we close it here. Please open a ticket in machine-drivers/discussion so we can set up the repo for you. These drivers are supposed to be generally used and tested against either one of the consumers; minikube and/or minishift https://github.com/machine-drivers/discussion/

[bassam]

I'm still missing something here. How is what I proposed different from vmware fusion (https://github.com/kubernetes/minikube/blob/master/pkg/minikube/drivers/vmwarefusion/driver.go)?

[gbraad]

VMware driver also did not get included in the repo and has been included in the machine-drivers repo instead : https://github.com/machine-drivers/docker-machine-driver-vmware the current driver in the repo is old and will likely be deprecated soon

…

On Mon, Apr 30, 2018 at 1:22 PM, Bassam Tabbara ***@***.***> wrote: I'm still missing something here. How is what I've proposed different from vmware fusion (https://github.com/kubernetes/minikube/blob/ master/pkg/minikube/drivers/vmwarefusion/driver.go)? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2756 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAHZjVI691laHz0qx6AiVVzUuvKb4Zpks5ttp-EgaJpZM4TeRqC> .

-- Gerard Braad | http://gbraad.nl [ Doing Open Source Matters ]

[bassam]

Looks like someone added the parallels driver to machine-drivers (see https://github.com/machine-drivers/docker-machine-parallels) already. What else needs to happen in the minikube repo to enable parallels?

[gbraad]

you would have to follow the same procedures as performed by the updated VMware driver. Ypou can track this in the PRs. But without any CI, it is unlikely support will be added directly in: #2606 (comment)

@anfernee might be able to inform you more about this, as he worked on the VMware side...