don't allow profile name to be less than 2 characters #9367

medyagh · 2020-10-01T00:23:05Z

closes #9366

k8s-ci-robot · 2020-10-01T00:23:22Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

TravisBuddy · 2020-10-01T00:28:48Z

Travis tests have failed

Hey @medyagh,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make test

PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.14.6.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
gofmt -s -w pkg/minikube/assets/assets.go
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.14.6.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
MINIKUBE_LDFLAGS="-X k8s.io/minikube/pkg/version.version=v1.13.1 -X k8s.io/minikube/pkg/version.isoVersion=v1.13.1 -X k8s.io/minikube/pkg/version.isoPath=minikube/iso -X k8s.io/minikube/pkg/version.gitCommitID="c4228b7f60358dab823d3674c0930c5a5a66f06a" -X k8s.io/minikube/pkg/version.storageProvisionerVersion=v3" ./test.sh
= schema_check ==========================================================
go: downloading github.com/xeipuuv/gojsonschema v0.0.0-20180618132009-1d523034197f
go: downloading github.com/xeipuuv/gojsonreference v0.0.0-20180127040603-bd5ef7bd5415
go: downloading github.com/xeipuuv/gojsonpointer v0.0.0-20180127040702-4e3ac2762d5f
ok
= go test ===============================================================
go: downloading github.com/machine-drivers/machine v0.7.1-0.20200810185219-7d42fed1b770
go: downloading github.com/juju/clock v0.0.0-20190205081909-9c5c9712527c
go: downloading github.com/google/go-github v17.0.0+incompatible
go: downloading github.com/spf13/cobra v1.0.0
go: downloading k8s.io/apimachinery v0.17.3
go: downloading github.com/mattn/go-isatty v0.0.12
go: downloading github.com/spf13/viper v1.7.0
go: downloading golang.org/x/crypto v0.0.0-20200510223506-06a226fb4e37
go: downloading github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b
go: downloading github.com/mitchellh/go-ps v0.0.0-20190716172923-621e5597135b
go: downloading github.com/spf13/afero v1.2.2
go: downloading github.com/spf13/jwalterweatherman v1.1.0
go: downloading github.com/docker/go-units v0.4.0
go: downloading k8s.io/client-go v0.17.3
go: downloading github.com/cloudfoundry-attic/jibber_jabber v0.0.0-20151120183258-bcc4c8345a21
go: downloading github.com/olekukonko/tablewriter v0.0.4
go: downloading github.com/cenkalti/backoff v2.2.1+incompatible
go: downloading github.com/afbjorklund/go-containerregistry v0.0.0-20200902152226-fbad78ec2813
go: downloading golang.org/x/text v0.3.2
go: downloading gopkg.in/ini.v1 v1.56.0
go: downloading github.com/google/go-querystring v1.0.0
go: downloading github.com/hashicorp/hcl v1.0.0
go: downloading github.com/cheggaaa/pb v1.0.27
go: downloading github.com/pelletier/go-toml v1.8.0
go: downloading github.com/hooklift/iso9660 v0.0.0-20170318115843-1cf07e5970d8
go: downloading golang.org/x/oauth2 v0.0.0-20200107190931-bf48bf16ab8d
go: downloading k8s.io/klog v1.0.0
go: downloading github.com/cheggaaa/pb/v3 v3.0.1
go: downloading github.com/mattn/go-runewidth v0.0.7
go: downloading golang.org/x/sync v0.0.0-20200317015054-43a5402ce75a
go: downloading github.com/shirou/gopsutil v2.18.12+incompatible
go: downloading github.com/libvirt/libvirt-go v3.4.0+incompatible
go: downloading github.com/mitchellh/mapstructure v1.3.1
go: downloading github.com/spf13/cast v1.3.1
go: downloading github.com/mattn/go-colorable v0.1.6
go: downloading github.com/blang/semver v3.5.0+incompatible
go: downloading golang.org/x/sys v0.0.0-20200523222454-059865788121
go: downloading github.com/juju/mutex v0.0.0-20180619145857-d21b13acf4bf
go: downloading github.com/docker/docker v1.4.2-0.20190924003213-a8608b5b67c7
go: downloading github.com/afbjorklund/go-getter v1.4.1-0.20190910175809-eb9f6c26742c
go: downloading github.com/pkg/errors v0.9.1
go: downloading github.com/google/gofuzz v1.1.0
go: downloading github.com/cloudevents/sdk-go/v2 v2.1.0
go: downloading github.com/hashicorp/go-safetemp v1.0.0
go: downloading github.com/aws/aws-sdk-go v1.31.6
go: downloading cloud.google.com/go v0.57.0
go: downloading k8s.io/api v0.17.3
go: downloading github.com/hashicorp/go-cleanhttp v0.5.1
go: downloading github.com/fsnotify/fsnotify v1.4.9
go: downloading github.com/opencontainers/go-digest v1.0.0-rc1
go: downloading github.com/phayes/freeport v0.0.0-20180830031419-95f893ade6f2
go: downloading github.com/c4milo/gotoolkit v0.0.0-20170318115440-bcc06269efa9
go: downloading github.com/mitchellh/go-testing-interface v1.0.0
go: downloading github.com/bgentry/go-netrc v0.0.0-20140422174119-9fd32a8b3d3d
go: downloading github.com/docker/cli v0.0.0-20200303162255-7d407207c304
go: downloading github.com/golang-collections/collections v0.0.0-20130729185459-604e922904d3
go: downloading github.com/otiai10/copy v1.0.2
go: downloading google.golang.org/api v0.25.0
go: downloading github.com/mitchellh/go-homedir v1.1.0
go: downloading k8s.io/kubectl v0.17.3
go: downloading github.com/hashicorp/go-version v1.2.0
go: downloading go.opencensus.io v0.22.3
go: downloading github.com/opencontainers/image-spec v1.0.1
go: downloading github.com/cpuguy83/go-md2man v1.0.10
go: downloading github.com/docker/go-connections v0.4.0
go: downloading github.com/cpuguy83/go-md2man/v2 v2.0.0
go: downloading github.com/fatih/color v1.9.0
go: downloading golang.org/x/net v0.0.0-20200520182314-0ba52f642ac2
go: downloading sigs.k8s.io/sig-storage-lib-external-provisioner v4.0.0+incompatible
go: downloading github.com/gogo/protobuf v1.3.1
go: downloading sigs.k8s.io/sig-storage-lib-external-provisioner/v5 v5.0.0
go: downloading github.com/ulikunitz/xz v0.5.7
go: downloading k8s.io/kubernetes v1.18.5
go: downloading github.com/pkg/browser v0.0.0-20160118053552-9302be274faa
go: downloading github.com/juju/errors v0.0.0-20190806202954-0232dcc7464d
go: downloading go.uber.org/zap v1.10.0
go: downloading github.com/MakeNowJust/heredoc v0.0.0-20170808103936-bb23615498cd
go: downloading github.com/prometheus/client_golang v1.4.1
go: downloading gopkg.in/inf.v0 v0.9.1
go: downloading github.com/VividCortex/ewma v1.1.1
go: downloading github.com/golang/protobuf v1.4.2
go: downloading github.com/magiconair/properties v1.8.1
go: downloading github.com/docker/distribution v2.7.1+incompatible
go: downloading go.uber.org/atomic v1.4.0
go: downloading github.com/googleapis/gnostic v0.3.0
go: downloading github.com/google/uuid v1.1.1
go: downloading google.golang.org/protobuf v1.24.0
go: downloading k8s.io/utils v0.0.0-20200324210504-a9aa75ae1b89
go: downloading github.com/russross/blackfriday v1.5.3-0.20200218234912-41c5fccfd6f6
go: downloading github.com/russross/blackfriday/v2 v2.0.1
go: downloading go.uber.org/multierr v1.1.0
go: downloading github.com/lightstep/tracecontext.go v0.0.0-20181129014701-1757c391b1ac
go: downloading github.com/beorn7/perks v1.0.1
go: downloading github.com/shurcooL/sanitized_anchor_name v1.0.0
go: downloading github.com/cespare/xxhash v1.1.0
go: downloading github.com/cespare/xxhash/v2 v2.1.1
go: downloading github.com/spf13/pflag v1.0.5
go: downloading gopkg.in/yaml.v2 v2.3.0
go: downloading github.com/miekg/dns v1.1.27
go: downloading google.golang.org/grpc v1.29.1
go: downloading github.com/google/go-cmp v0.4.1
go: downloading github.com/sayboras/dockerclient v1.0.0
go: downloading github.com/prometheus/common v0.9.1
go: downloading github.com/machine-drivers/docker-machine-driver-vmware v0.1.1
go: downloading golang.org/x/time v0.0.0-20200416051211-89c76fbcd5d1
go: downloading github.com/json-iterator/go v1.1.9
go: downloading github.com/prometheus/client_model v0.2.0
go: downloading github.com/docker/docker-credential-helpers v0.6.3
go: downloading golang.org/x/exp v0.0.0-20200224162631-6cc2880d07d6
go: downloading github.com/davecgh/go-spew v1.1.1
go: downloading github.com/intel-go/cpuid v0.0.0-20181003105527-1a4a6f06a1c6
go: downloading github.com/golang/groupcache v0.0.0-20200121045136-8c9f03a8e57e
go: downloading sigs.k8s.io/yaml v1.2.0
go: downloading github.com/google/slowjam v0.0.0-20200530021616-df27e642fe7b
go: downloading cloud.google.com/go/storage v1.8.0
go: downloading github.com/modern-go/reflect2 v1.0.1
go: downloading github.com/kballard/go-shellquote v0.0.0-20180428030007-95032a82bc51
go: downloading github.com/pkg/profile v0.0.0-20161223203901-3a8809bd8a80
go: downloading github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd
go: downloading github.com/sirupsen/logrus v1.6.0
go: downloading github.com/docker/spdystream v0.0.0-20160310174837-449fdfce4d96
go: downloading github.com/imdario/mergo v0.3.9
go: downloading github.com/matttproud/golang_protobuf_extensions v1.0.1
go: downloading github.com/mitchellh/go-wordwrap v1.0.0
go: downloading github.com/subosito/gotenv v1.2.0
go: downloading github.com/jmespath/go-jmespath v0.3.0
go: downloading github.com/hashicorp/golang-lru v0.5.3
go: downloading google.golang.org/genproto v0.0.0-20200527145253-8367513e4ece
go: downloading github.com/containerd/containerd v1.3.1-0.20191213020239-082f7e3aed57
go: downloading k8s.io/kube-openapi v0.0.0-20200410145947-61e04a5be9a6
go: downloading github.com/prometheus/procfs v0.0.8
go: downloading k8s.io/cluster-bootstrap v0.17.3
go: downloading github.com/googleapis/gax-go v2.0.2+incompatible
go: downloading k8s.io/component-base v0.17.3
go: downloading github.com/googleapis/gax-go/v2 v2.0.5
go: downloading github.com/pmezard/go-difflib v1.0.0
go: downloading github.com/evanphx/json-patch v4.5.0+incompatible
go: downloading golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543
ok  	k8s.io/minikube/cmd/minikube/cmd	8.014s	coverage: 18.4% of statements
ok  	k8s.io/minikube/cmd/minikube/cmd/config	0.050s	coverage: 21.5% of statements
ok  	k8s.io/minikube/pkg/addons	0.047s	coverage: 48.6% of statements
ok  	k8s.io/minikube/pkg/drivers	0.007s	coverage: 19.6% of statements
ok  	k8s.io/minikube/pkg/drivers/hyperkit	0.003s	coverage: 77.3% of statements
ok  	k8s.io/minikube/pkg/drivers/kic/oci	0.017s	coverage: 7.4% of statements
ok  	k8s.io/minikube/pkg/drivers/kvm	0.028s	coverage: 2.3% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper	0.854s	coverage: 55.7% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/bsutil	0.115s	coverage: 62.4% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/bsutil/ktmpl	0.013s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/images	0.003s	coverage: 82.0% of statements
ok  	k8s.io/minikube/pkg/minikube/cluster	0.073s	coverage: 14.9% of statements
ok  	k8s.io/minikube/pkg/minikube/command	0.031s	coverage: 4.2% of statements
{
    "memory": 2
}
{
    "memory": 2
}
{
    "ReminderWaitPeriodInHours": 99,
    "cpus": 4,
    "disk-size": "20g",
    "driver": "test-driver",
    "log_dir": "/etc/hosts",
    "show-libmachine-logs": true,
    "v": 5
}
{
    "ReminderWaitPeriodInHours": 99,
    "cpus": 4,
    "disk-size": "20g",
    "driver": "test-driver",
    "log_dir": "/etc/hosts",
    "show-libmachine-logs": true,
    "v": 5
}
invalid value "foo" for flag -e: invalid value: must contain at least one period: "foo"
Usage of test:
  -e value
    	usage
invalid value "foo.bar" for flag -e: invalid value: must contain one equal sign: "foo.bar"
Usage of test:
  -e value
    	usage
invalid value "foo.bar.baz" for flag -e: invalid value: must contain one equal sign: "foo.bar.baz"
Usage of test:
  -e value
    	usage
invalid value "foo=bar" for flag -e: invalid value: must contain at least one period: "foo=bar"
Usage of test:
  -e value
    	usage
invalid value "foo=bar.baz" for flag -e: invalid value: must contain one equal sign: "foo=bar.baz"
Usage of test:
  -e value
    	usage
invalid value "foo" for flag -e: invalid value: must contain at least one period: "foo"
Usage of test:
  -e value
    	usage
invalid value "foo" for flag -e: invalid value: must contain at least one period: "foo"
Usage of test:
  -e value
    	usage
invalid value "foo" for flag -e: invalid value: must contain at least one period: "foo"
Usage of test:
  -e value
    	usage
invalid value "foo" for flag -e: invalid value: must contain at least one period: "foo"
Usage of test:
  -e value
    	usage
--- FAIL: TestProfileNameValid (0.00s)
    --- FAIL: TestProfileNameValid/n (0.00s)
        profile_test.go:104: expected ProfileNameValid(n)=true but got false 
    --- FAIL: TestProfileNameValid/1 (0.00s)
        profile_test.go:104: expected ProfileNameValid(1)=true but got false 
FAIL
coverage: 68.1% of statements
FAIL	k8s.io/minikube/pkg/minikube/config	0.213s
ok  	k8s.io/minikube/pkg/minikube/cruntime	0.070s	coverage: 36.7% of statements
ok  	k8s.io/minikube/pkg/minikube/docker	0.032s	coverage: 20.8% of statements
ok  	k8s.io/minikube/pkg/minikube/driver	0.033s	coverage: 33.9% of statements
ok  	k8s.io/minikube/pkg/minikube/extract	0.006s	coverage: 58.6% of statements
ok  	k8s.io/minikube/pkg/minikube/image	0.019s	coverage: 3.0% of statements
ok  	k8s.io/minikube/pkg/minikube/kubeconfig	0.030s	coverage: 81.2% of statements
ok  	k8s.io/minikube/pkg/minikube/localpath	0.011s	coverage: 49.3% of statements
ok  	k8s.io/minikube/pkg/minikube/logs	0.049s	coverage: 1.3% of statements
ok  	k8s.io/minikube/pkg/minikube/machine	1.088s	coverage: 35.9% of statements
ok  	k8s.io/minikube/pkg/minikube/mustload	0.067s	coverage: 10.5% of statements
ok  	k8s.io/minikube/pkg/minikube/notify	0.039s	coverage: 92.9% of statements
ok  	k8s.io/minikube/pkg/minikube/out	0.094s	coverage: 66.0% of statements
ok  	k8s.io/minikube/pkg/minikube/out/register	0.015s	coverage: 54.5% of statements
ok  	k8s.io/minikube/pkg/minikube/perf	4.023s	coverage: 21.1% of statements
ok  	k8s.io/minikube/pkg/minikube/proxy	0.012s	coverage: 68.7% of statements
ok  	k8s.io/minikube/pkg/minikube/reason	0.009s	coverage: 80.0% of statements
ok  	k8s.io/minikube/pkg/minikube/registry	0.011s	coverage: 75.5% of statements
ok  	k8s.io/minikube/pkg/minikube/service	0.077s	coverage: 84.2% of statements
ok  	k8s.io/minikube/pkg/minikube/shell	0.003s	coverage: 97.1% of statements
ok  	k8s.io/minikube/pkg/minikube/storageclass	0.042s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/style	0.002s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/sysinit	0.029s	coverage: 6.5% of statements
ok  	k8s.io/minikube/pkg/minikube/translate	0.015s	coverage: 10.5% of statements
ok  	k8s.io/minikube/pkg/minikube/tunnel	1.781s	coverage: 64.2% of statements
ok  	k8s.io/minikube/pkg/util	0.942s	coverage: 75.7% of statements
ok  	k8s.io/minikube/pkg/util/lock	0.006s	coverage: 22.2% of statements
ok  	k8s.io/minikube/pkg/util/retry	0.008s	coverage: 0.0% of statements
FAIL
Makefile:320: recipe for target 'test' failed
make: *** [test] Error 32

TravisBuddy Request Identifier: 10e88000-037d-11eb-b614-dd2b96524a99

codecov-commenter · 2020-10-01T00:37:22Z

Codecov Report

Merging #9367 into master will not change coverage.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##           master    #9367   +/-   ##
=======================================
  Coverage   29.35%   29.35%           
=======================================
  Files         170      170           
  Lines       10362    10362           
=======================================
  Hits         3042     3042           
  Misses       6896     6896           
  Partials      424      424

Impacted Files	Coverage Δ
cmd/minikube/cmd/start.go	`9.45% <0.00%> (ø)`
pkg/minikube/config/profile.go	`66.94% <100.00%> (ø)`

priyawadhwa

lgtm, just one comment

priyawadhwa · 2020-10-05T14:55:14Z

cmd/minikube/cmd/start.go

@@ -155,7 +155,7 @@ func runStart(cmd *cobra.Command, args []string) {

 	if !config.ProfileNameValid(ClusterFlagValue()) {
 		out.WarningT("Profile name '{{.name}}' is not valid", out.V{"name": ClusterFlagValue()})
-		exit.Message(reason.Usage, "Only alphanumeric and dashes '-' are permitted. Minimum 1 character, starting with alphanumeric.")
+		exit.Message(reason.Usage, "Only alphanumeric and dashes '-' are permitted. Minimum 2 character, starting with alphanumeric.")


nit: minimum 2 character should be minimum 2 characters

don't allow profile name to be less than 2 characters

f71272c

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 1, 2020

k8s-ci-robot requested review from prasadkatti and tstromberg October 1, 2020 00:23

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2020

medyagh added 2 commits September 30, 2020 17:24

add unit test

1048e6d

unit test

e178684

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 1, 2020

unit test

437aed3

priyawadhwa approved these changes Oct 5, 2020

View reviewed changes

review comments

dc0918e

medyagh merged commit 5614ed0 into kubernetes:master Oct 5, 2020

medyagh deleted the pname_length branch March 2, 2021 21:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

don't allow profile name to be less than 2 characters #9367

don't allow profile name to be less than 2 characters #9367

medyagh commented Oct 1, 2020 •

edited

Loading

k8s-ci-robot commented Oct 1, 2020

TravisBuddy commented Oct 1, 2020

codecov-commenter commented Oct 1, 2020

priyawadhwa left a comment

priyawadhwa Oct 5, 2020

don't allow profile name to be less than 2 characters #9367

don't allow profile name to be less than 2 characters #9367

Conversation

medyagh commented Oct 1, 2020 • edited Loading

k8s-ci-robot commented Oct 1, 2020

TravisBuddy commented Oct 1, 2020

Travis tests have failed

1st Build

TravisBuddy Request Identifier: 10e88000-037d-11eb-b614-dd2b96524a99

codecov-commenter commented Oct 1, 2020

Codecov Report

priyawadhwa left a comment

Choose a reason for hiding this comment

priyawadhwa Oct 5, 2020

Choose a reason for hiding this comment

medyagh commented Oct 1, 2020 •

edited

Loading