Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not allow one letter profile names #9366

Closed
medyagh opened this issue Sep 30, 2020 · 1 comment Β· Fixed by #9367
Closed

do not allow one letter profile names #9366

medyagh opened this issue Sep 30, 2020 · 1 comment Β· Fixed by #9367
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@medyagh
Copy link
Member

medyagh commented Sep 30, 2020

docker does not allow volume names shorter than 2 letters.
which will cause minikube to crash on docker driver

medya@~/workspace/minikube (docker_network) $ ./out/minikube start -p p
πŸ˜„  [p] minikube v1.13.1 on Darwin 10.15.6
✨  Automatically selected the docker driver. Other choices: hyperkit, virtualbox
πŸ‘  Starting control plane node p in cluster p
πŸ”₯  Creating docker container (CPUs=2, Memory=4000MB) ...
🀦  StartHost failed, but will try again: creating host: create: creating: setting up container node: creating volume for p container: docker volume create p --label name.minikube.sigs.k8s.io=p --label created_by.minikube.sigs.k8s.io=true: exit status 1
stdout:

stderr:
Error response from daemon: create p: volume name is too short, names should be at least two alphanumeric characters

🀷  docker "p" container is missing, will recreate.
πŸ”₯  Creating docker container (CPUs=2, Memory=4000MB) ...
😿  Failed to start docker container. Running "minikube delete -p p" may fix it: recreate: creating host: create: creating: setting up container node: creating volume for p container: docker volume create p --label name.minikube.sigs.k8s.io=p --label created_by.minikube.sigs.k8s.io=true: exit status 1
stdout:

stderr:
Error response from daemon: create p: volume name is too short, names should be at least two alphanumeric characters

❗  Startup with docker driver failed, trying with alternate driver hyperkit: Failed to start host: recreate: creating host: create: creating: setting up container node: creating volume for p container: docker volume create p --label name.minikube.sigs.k8s.io=p --label created_by.minikube.sigs.k8s.io=true: exit status 1
stdout:

stderr:
Error response from daemon: create p: volume name is too short, names should be at least two alphanumeric characters

πŸ”₯  Deleting "p" in docker ...
πŸ”₯  Removing /Users/medya/.minikube/machines/p ...
πŸ’€  Removed all traces of the "p" cluster.
πŸ’Ύ  Downloading driver docker-machine-driver-hyperkit:
    > docker-machine-driver-hyperkit.sha256: 65 B / 65 B [---] 100.00% ? p/s 0s
    > docker-machine-driver-hyperkit: 10.90 MiB / 10.90 MiB  100.00% 11.74 MiB 
πŸ”‘  The 'hyperkit' driver requires elevated permissions. The following commands will be executed:

    $ sudo chown root:wheel /Users/medya/.minikube/bin/docker-machine-driver-hyperkit 
    $ sudo chmod u+s /Users/medya/.minikube/bin/docker-machine-driver-hyperkit 


Password: 

we should not allow single letter profile names

@medyagh medyagh added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/bug Categorizes issue or PR as related to a bug. labels Sep 30, 2020
@tiejl
Copy link

tiejl commented Oct 1, 2020

You're welcome to assign me on this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants