fallback to alternate drivers on failure #7389

sharifelgamal · 2020-04-02T22:05:22Z

If the user doesn't explicitly supply a choice of driver to minikube start via the driver flag or config and there's a failure, we will now go down the list of alternate driver choices and retry starting the cluster with that.

out/minikube start
😄  minikube v1.9.2 on Darwin 10.14.6
✨  Automatically selected the hyperkit driver
❗  Startup with hyperkit driver failed, trying with docker: OH NO RANDOM FAILURE
💀  Removed all traces of the "minikube" cluster.
👍  Starting control plane node m01 in cluster minikube
🚜  Pulling base image ...
🔥  Creating Kubernetes in docker container with (CPUs=2) (4 available), Memory=1989MB (1989MB available) ...
🐳  Preparing Kubernetes v1.18.0 on Docker 19.03.2 ...
    ▪ kubeadm.pod-network-cidr=10.244.0.0/16
🌟  Enabling addons: default-storageclass, storage-provisioner
🏄  Done! kubectl is now configured to use "minikube"

Specifying a driver will still fail as expected

out/minikube start --driver=hyperkit
😄  minikube v1.9.2 on Darwin 10.14.6
✨  Using the hyperkit driver based on user configuration

💣  error provisioning host: OH NO RANDOM FAILURE

😿  minikube is exiting due to an error. If the above message is not useful, open an issue:
👉  https://github.com/kubernetes/minikube/issues/new/choose

Starting Kubernetes fails as expected as well, we only fallback on provisioning failures:

😄  minikube v1.9.2 on Darwin 10.14.6
✨  Automatically selected the hyperkit driver
👍  Starting control plane node m01 in cluster minikube
🔥  Creating hyperkit VM (CPUs=2, Memory=4000MB, Disk=20000MB) ...

💣  failed to start node: startup failed: OH NO RANDOM FAILURE

😿  minikube is exiting due to an error. If the above message is not useful, open an issue:
👉  https://github.com/kubernetes/minikube/issues/new/choose

…allback

k8s-ci-robot · 2020-04-02T22:06:07Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [sharifelgamal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tstromberg

On the surface - the PR does the right thing. I'd like to constrain what gets considered for fall-through, so that we can improve the UX for non-driver configuration errors, such as users passing in bad configuration to the apiserver.

How bad would it be to split the code up so that the driver fall-through only occurs on machine provisioning failures? That should cover ~98% of the issues that driver fall-through would fix without forcing users with bad apiserver flags to wait 20 minutes to fall through each driver they have.

tstromberg · 2020-04-02T22:14:31Z

cmd/minikube/cmd/start.go

+	if err != nil && !specified {
+		// Walk down the rest of the options
+		for _, alt := range alts {
+			out.WarningT("Startup with {{.old_driver}} driver failed, trying with {{.new_driver}}.", out.V{"old_driver": ds.Name, "new_driver": alt.Name})


Let's start by outputting the error message. It's unlikely to be terribly long, and it should be very informative.

tstromberg · 2020-04-02T22:16:57Z

cmd/minikube/cmd/start.go

+			// Delete the existing cluster and try again with the next driver on the list
+			profile, err := config.LoadProfile(ClusterFlagValue())
+			if err != nil {
+				out.ErrT(out.Meh, `"{{.name}}" profile does not exist, trying anyways.`, out.V{"name": ClusterFlagValue()})


I think this can be hidden in a log message.

tstromberg · 2020-04-02T22:18:14Z

cmd/minikube/cmd/start.go

@@ -388,6 +423,8 @@ func runStart(cmd *cobra.Command, args []string) {
 	if err := showKubectlInfo(kubeconfig, k8sVersion, cc.Name); err != nil {


I think this can be moved out of startWithDriver and into the main loop. It raises no error, but it also has nothing to do with drivers.

medyagh · 2020-04-02T22:34:04Z

This is a super neat feature! Thank you.
I agree with Thomas on only falling back to the other driver if it's a provisioning problem.

sharifelgamal · 2020-04-02T23:16:59Z

Makes sense, it's just going to require a more substantial refactor of node.Start. I'll work on it.

…allback

sharifelgamal · 2020-04-06T21:34:15Z

This should be ready for review again.

sharifelgamal · 2020-04-06T23:48:34Z

/ok-to-test

minikube-pr-bot · 2020-04-06T23:52:42Z

Error: running mkcmp: exit status 1

tstromberg · 2020-04-07T15:36:51Z

Looks great!

Thought for future development: I wonder if we should remember the default driver that finally succeeds. I guess we sort of do, because we only drop the driver if the profile is deleted.

tstromberg · 2020-04-07T16:11:43Z

I tested this PR locally by:

Creating /tmp/hyperkit as:

#!/bin/sh
echo "hyperkit: v0.20190802-4-g97f091"

chmod 755 /tmp/hyperkit
./out/minikube delete
./out/minikube start

Unfortunately, it didn't seem to fallback in this case: https://gist.github.com/tstromberg/bdd8f5c3a54ab2f4ec5ef5570fcc1d46

Any chance you could add a fallback integration test to make sure this doesn't get accidentally broken in the future? It's somewhat tricky, but so is start.go. We may want to set the whitelist up to only work in environments where we're sure of a fallback -- so perhaps hyperkit -> Docker for Desktop, or something on Linux?

sharifelgamal · 2020-04-07T16:26:07Z

Good catch, it's because part of provision are still exiting instead of returning the error. I'll fix it. I can try to add a test as well, my worry is that it will be brittle.

As for making sure for fallback, I figured the list of alternate drivers that we return was a pretty safe list to iterate down, any reason to not think so?

minikube-pr-bot · 2020-04-08T01:36:58Z

All Times minikube: [ 67.876060 65.834906 65.802959]
All Times Minikube (PR 7389): [ 69.120302 64.192413 66.503137]

Average minikube: 66.504641
Average Minikube (PR 7389): 66.605284

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 7389) |
+----------------------+-----------+--------------------+
| minikube v           |  0.163552 |           0.146929 |
| Creating kvm2        | 41.577181 |          40.876645 |
| Preparing Kubernetes | 22.647598 |          23.350789 |
| Pulling images       |           |                    |
| Launching Kubernetes |           |                    |
| Waiting for cluster  |           |                    |
+----------------------+-----------+--------------------+

minikube-pr-bot · 2020-04-09T01:02:11Z

Times for minikube: [68.61437737799999 63.79203957799999 65.86677142799999]
Average time for minikube: 66.09106279466666

Times for Minikube (PR 7389): [64.82932214 64.66789235799999 64.722607542]
Average time for Minikube (PR 7389): 64.73994068

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7389) |
+--------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian    |  0.054018 |           0.053343 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.020360 |           0.020695 |
| on user configuration          |           |                    |
| * Starting control plane node  |  0.003532 |                    |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 41.135328 |          39.732921 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 22.644777 |          22.607860 |
| on Docker 19.03.8 ...          |           |                    |
| * Enabling addons:             |  2.140460 |           2.249266 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.087670 |           0.068158 |
| configured to use "minikube"   |           |                    |
|                                |  0.004917 |           0.003153 |
+--------------------------------+-----------+--------------------+

…allback

minikube-pr-bot · 2020-04-09T02:29:24Z

Times for minikube: [66.838103044 64.32249093799999 64.645972742]
Average time for minikube: 65.26885557466666

Times for Minikube (PR 7389): [65.491807319 66.289239556 66.402680428]
Average time for Minikube (PR 7389): 66.06124243433334

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7389) |
+--------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian    |  0.054010 |           0.055164 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.020317 |           0.021438 |
| on user configuration          |           |                    |
| * Starting control plane node  |  0.003182 |                    |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.837730 |          40.986514 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 22.092643 |          22.903455 |
| on Docker 19.03.8 ...          |           |                    |
| * Enabling addons:             |  2.173459 |           2.011153 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.084156 |           0.076375 |
| configured to use "minikube"   |           |                    |
|                                |  0.003360 |           0.003350 |
+--------------------------------+-----------+--------------------+

minikube-pr-bot · 2020-04-09T03:55:28Z

Times for minikube: [66.142932129 65.477336764 64.878701535]
Average time for minikube: 65.49965680933333

Times for Minikube (PR 7389): [66.820549268 67.329258823 87.61991428200001]
Average time for Minikube (PR 7389): 73.923240791

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7389) |
+--------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian    |  0.054628 |           0.053842 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.020130 |           0.020186 |
| on user configuration          |           |                    |
| * Starting control plane node  |  0.003138 |                    |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 41.073494 |          42.239785 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 22.093093 |          29.300517 |
| on Docker 19.03.8 ...          |           |                    |
| * Enabling addons:             |  2.171976 |           2.223940 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.080248 |           0.077283 |
| configured to use "minikube"   |           |                    |
|                                |  0.002948 |           0.003000 |
+--------------------------------+-----------+--------------------+

minikube-pr-bot · 2020-04-09T05:20:53Z

Times for minikube: [68.941013188 67.50117359000001 65.659430288]
Average time for minikube: 67.36720568866667

Times for Minikube (PR 7389): [66.569717708 65.78811284500001 63.950682795]
Average time for Minikube (PR 7389): 65.43617111600001

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7389) |
+--------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian    |  0.054337 |           0.053987 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.019731 |           0.020578 |
| on user configuration          |           |                    |
| * Starting control plane node  |  0.004726 |                    |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 41.962251 |          40.076687 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 22.945349 |          23.281452 |
| on Docker 19.03.8 ...          |           |                    |
| * Enabling addons:             |  2.300851 |           1.919940 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.076890 |           0.074646 |
| configured to use "minikube"   |           |                    |
|                                |  0.003071 |           0.003559 |
+--------------------------------+-----------+--------------------+

minikube-pr-bot · 2020-04-09T06:53:37Z

Times for minikube: [65.28964660499999 65.799649482 67.564352931]
Average time for minikube: 66.21788300600001

Times for Minikube (PR 7389): [64.47649222899999 68.37589096399999 68.392623414]
Average time for Minikube (PR 7389): 67.081668869

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7389) |
+--------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian    |  0.054949 |           0.052882 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.019842 |           0.019319 |
| on user configuration          |           |                    |
| * Starting control plane node  |  0.004106 |                    |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.551604 |          41.975475 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 23.046122 |          23.297602 |
| on Docker 19.03.8 ...          |           |                    |
| * Enabling addons:             |  2.464101 |           1.649312 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.073864 |           0.079833 |
| configured to use "minikube"   |           |                    |
|                                |  0.003296 |           0.003909 |
+--------------------------------+-----------+--------------------+

minikube-pr-bot · 2020-04-09T08:27:24Z

Times for minikube: [68.637234354 66.245775554 69.42458668]
Average time for minikube: 68.10253219600001

Times for Minikube (PR 7389): [68.379620515 65.797629348 64.993510062]
Average time for Minikube (PR 7389): 66.39025330833333

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7389) |
+--------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian    |  0.055704 |           0.054716 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.020960 |           0.020575 |
| on user configuration          |           |                    |
| * Starting control plane node  |  0.003305 |                    |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 42.232965 |          40.878432 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 23.433910 |          23.241433 |
| on Docker 19.03.8 ...          |           |                    |
| * Enabling addons:             |  2.276805 |           2.110962 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.075802 |           0.076621 |
| configured to use "minikube"   |           |                    |
|                                |  0.003082 |           0.003191 |
+--------------------------------+-----------+--------------------+

minikube-pr-bot · 2020-04-09T09:53:12Z

Times for minikube: [67.451256079 65.720750475 65.56211417499999]
Average time for minikube: 66.24470690966666

Times for Minikube (PR 7389): [66.76690671099999 64.385185313 66.152168297]
Average time for Minikube (PR 7389): 65.76808677366665

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7389) |
+--------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian    |  0.054557 |           0.053335 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.020336 |           0.020284 |
| on user configuration          |           |                    |
| * Starting control plane node  |  0.003250 |                    |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 42.042831 |          41.027680 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 22.062036 |          22.271997 |
| on Docker 19.03.8 ...          |           |                    |
| * Enabling addons:             |  1.970453 |           2.310856 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.088373 |           0.075732 |
| configured to use "minikube"   |           |                    |
|                                |  0.002871 |           0.004382 |
+--------------------------------+-----------+--------------------+

minikube-pr-bot · 2020-04-09T11:19:00Z

Times for minikube: [67.532975101 72.424078156 65.45978481700003]
Average time for minikube: 68.472279358

Times for Minikube (PR 7389): [65.428628975 68.92717355500001 68.109054576]
Average time for Minikube (PR 7389): 67.488285702

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7389) |
+--------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian    |  0.056269 |           0.054733 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.020519 |           0.021278 |
| on user configuration          |           |                    |
| * Starting control plane node  |  0.004057 |                    |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 42.287764 |          41.556458 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 23.724263 |          23.365702 |
| on Docker 19.03.8 ...          |           |                    |
| * Enabling addons:             |  2.296079 |           2.410320 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.079893 |           0.072119 |
| configured to use "minikube"   |           |                    |
|                                |  0.003435 |           0.004601 |
+--------------------------------+-----------+--------------------+

tstromberg · 2020-04-09T11:57:23Z

Please merge when ready.

minikube-pr-bot · 2020-04-09T12:45:03Z

Times for minikube: [67.93204453999999 65.10946705 67.430150645]
Average time for minikube: 66.82388741166666

Times for Minikube (PR 7389): [67.644456516 65.822593143 66.893802751]
Average time for Minikube (PR 7389): 66.78695080333334

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7389) |
+--------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian    |  0.055841 |           0.055615 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.020591 |           0.020768 |
| on user configuration          |           |                    |
| * Starting control plane node  |  0.003970 |                    |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.978764 |          41.083676 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 23.123860 |          23.359385 |
| on Docker 19.03.8 ...          |           |                    |
| * Enabling addons:             |  2.558522 |           2.190638 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.077378 |           0.068683 |
| configured to use "minikube"   |           |                    |
|                                |  0.004961 |           0.003398 |
+--------------------------------+-----------+--------------------+

minikube-pr-bot · 2020-04-09T13:50:19Z

Times for minikube: [67.603174412 67.073093269 66.14986645600001]
Average time for minikube: 66.94204471233333

Times for Minikube (PR 7389): [67.865186992 67.294624359 66.32565942500001]
Average time for Minikube (PR 7389): 67.161823592

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7389) |
+--------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian    |  0.055191 |           0.056215 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.020616 |           0.021003 |
| on user configuration          |           |                    |
| * Starting control plane node  |  0.003351 |                    |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 42.009281 |          41.093466 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 22.527399 |          23.754852 |
| on Docker 19.03.8 ...          |           |                    |
| * Enabling addons:             |  2.240385 |           2.153761 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.082611 |           0.074834 |
| configured to use "minikube"   |           |                    |
|                                |  0.003212 |           0.003314 |
+--------------------------------+-----------+--------------------+

minikube-pr-bot · 2020-04-09T14:56:00Z

Times for minikube: [70.59345408399999 67.8515118 67.24457781299999]
Average time for minikube: 68.56318123233332

Times for Minikube (PR 7389): [67.30720398200002 65.42459162399999 66.23458923800001]
Average time for Minikube (PR 7389): 66.32212828133333

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7389) |
+--------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian    |  0.055459 |           0.056372 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.020528 |           0.020345 |
| on user configuration          |           |                    |
| * Starting control plane node  |  0.003286 |                    |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 42.518117 |          41.408653 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 23.484723 |          22.649741 |
| on Docker 19.03.8 ...          |           |                    |
| * Enabling addons:             |  2.395545 |           2.105344 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.080914 |           0.074571 |
| configured to use "minikube"   |           |                    |
|                                |  0.004610 |           0.003954 |
+--------------------------------+-----------+--------------------+

minikube-pr-bot · 2020-04-09T16:00:31Z

Times for minikube: [64.612109691 66.194494277 63.025563761]
Average time for minikube: 64.61072257633333

Times for Minikube (PR 7389): [68.96494924 64.216728601 62.42923606]
Average time for Minikube (PR 7389): 65.203637967

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7389) |
+--------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian    |  0.055783 |           0.056519 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.020571 |           0.021064 |
| on user configuration          |           |                    |
| * Starting control plane node  |  0.003513 |                    |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 39.823638 |          41.368873 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 22.585679 |          21.588351 |
| on Docker 19.03.8 ...          |           |                    |
| * Enabling addons:             |  2.038974 |           2.087540 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.078519 |           0.073172 |
| configured to use "minikube"   |           |                    |
|                                |  0.004047 |           0.004684 |
+--------------------------------+-----------+--------------------+

…allback

minikube-pr-bot · 2020-04-09T18:23:45Z

Times for minikube: [71.553304557 65.434464812 64.755014035]
Average time for minikube: 67.247594468

Times for Minikube (PR 7389): [65.909565411 62.134405146999995 72.403847718]
Average time for Minikube (PR 7389): 66.81593942533334

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7389) |
+--------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian    |  0.054035 |           0.054502 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.018977 |           0.020194 |
| on user configuration          |           |                    |
| * Starting control plane node  |  0.003690 |           0.003693 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 41.932935 |          41.770993 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 22.824559 |          22.690418 |
| on Docker 19.03.8 ...          |           |                    |
| * Enabling addons:             |  2.318468 |           2.193656 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.090874 |           0.077488 |
| configured to use "minikube"   |           |                    |
|                                |  0.004056 |           0.004994 |
+--------------------------------+-----------+--------------------+

sharifelgamal added 6 commits April 1, 2020 17:32

merge

ac1b3b0

Merge branch 'master' of github.com:kubernetes/minikube into driver-f…

357b5bb

…allback

failback to alternate drivers if startup fails with automatic choice

26c7471

Merge branch 'master' of github.com:kubernetes/minikube into driver-f…

af8d01d

…allback

make sure to print error on failure

dd957ff

remove random failure for testing

b66447e

sharifelgamal requested review from tstromberg and medyagh April 2, 2020 22:05

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 2, 2020

k8s-ci-robot requested a review from RA489 April 2, 2020 22:06

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2020

fix lint

31f225d

tstromberg suggested changes Apr 2, 2020

View reviewed changes

sharifelgamal added 5 commits April 3, 2020 17:46

only failback to next driver if provisioning fails

3d037a8

Merge branch 'master' of github.com:kubernetes/minikube into driver-f…

66f9e13

…allback

Merge branch 'master' of github.com:kubernetes/minikube into driver-f…

f290aa9

…allback

split out node provisioning and starting kubernetes

78595b1

actually error out when driver is specified

eb42d16

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 6, 2020

sharifelgamal requested a review from tstromberg April 7, 2020 00:44

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 9, 2020

Merge branch 'master' of github.com:kubernetes/minikube into driver-f…

c40a942

…allback

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 9, 2020

tstromberg approved these changes Apr 9, 2020

View reviewed changes

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 9, 2020

Merge branch 'master' into driver-fallback

aee3c1d

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 9, 2020

sharifelgamal added 5 commits April 9, 2020 09:32

fix node name regression

d2dbf53

make alternate driver text more clear

198247d

Merge branch 'master' of github.com:kubernetes/minikube into driver-f…

e4b4a5a

…allback

fix build failure

9853274

fix build errors for realsies this time

322b5d5

sharifelgamal merged commit 527bbcd into kubernetes:master Apr 9, 2020

afbjorklund mentioned this pull request Feb 19, 2021

When docker driver fails, we try to use an (unspecified) external VM instead #10516

Closed

afbjorklund mentioned this pull request May 11, 2021

Fix error picking non-default alternate drivers #11371

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fallback to alternate drivers on failure #7389

fallback to alternate drivers on failure #7389

sharifelgamal commented Apr 2, 2020 •

edited

Loading

k8s-ci-robot commented Apr 2, 2020

tstromberg left a comment •

edited

Loading

tstromberg Apr 2, 2020

tstromberg Apr 2, 2020

tstromberg Apr 2, 2020

medyagh commented Apr 2, 2020

sharifelgamal commented Apr 2, 2020

sharifelgamal commented Apr 6, 2020

sharifelgamal commented Apr 6, 2020

minikube-pr-bot commented Apr 6, 2020

tstromberg commented Apr 7, 2020

tstromberg commented Apr 7, 2020

sharifelgamal commented Apr 7, 2020

minikube-pr-bot commented Apr 8, 2020

minikube-pr-bot commented Apr 9, 2020

minikube-pr-bot commented Apr 9, 2020

minikube-pr-bot commented Apr 9, 2020

minikube-pr-bot commented Apr 9, 2020

minikube-pr-bot commented Apr 9, 2020

minikube-pr-bot commented Apr 9, 2020

minikube-pr-bot commented Apr 9, 2020

minikube-pr-bot commented Apr 9, 2020

tstromberg commented Apr 9, 2020

minikube-pr-bot commented Apr 9, 2020

minikube-pr-bot commented Apr 9, 2020

minikube-pr-bot commented Apr 9, 2020

minikube-pr-bot commented Apr 9, 2020

minikube-pr-bot commented Apr 9, 2020

		@@ -388,6 +423,8 @@ func runStart(cmd *cobra.Command, args []string) {
		if err := showKubectlInfo(kubeconfig, k8sVersion, cc.Name); err != nil {

fallback to alternate drivers on failure #7389

fallback to alternate drivers on failure #7389

Conversation

sharifelgamal commented Apr 2, 2020 • edited Loading

k8s-ci-robot commented Apr 2, 2020

tstromberg left a comment • edited Loading

Choose a reason for hiding this comment

tstromberg Apr 2, 2020

Choose a reason for hiding this comment

tstromberg Apr 2, 2020

Choose a reason for hiding this comment

tstromberg Apr 2, 2020

Choose a reason for hiding this comment

medyagh commented Apr 2, 2020

sharifelgamal commented Apr 2, 2020

sharifelgamal commented Apr 6, 2020

sharifelgamal commented Apr 6, 2020

minikube-pr-bot commented Apr 6, 2020

tstromberg commented Apr 7, 2020

tstromberg commented Apr 7, 2020

sharifelgamal commented Apr 7, 2020

minikube-pr-bot commented Apr 8, 2020

minikube-pr-bot commented Apr 9, 2020

minikube-pr-bot commented Apr 9, 2020

minikube-pr-bot commented Apr 9, 2020

minikube-pr-bot commented Apr 9, 2020

minikube-pr-bot commented Apr 9, 2020

minikube-pr-bot commented Apr 9, 2020

minikube-pr-bot commented Apr 9, 2020

minikube-pr-bot commented Apr 9, 2020

tstromberg commented Apr 9, 2020

minikube-pr-bot commented Apr 9, 2020

minikube-pr-bot commented Apr 9, 2020

minikube-pr-bot commented Apr 9, 2020

minikube-pr-bot commented Apr 9, 2020

minikube-pr-bot commented Apr 9, 2020

sharifelgamal commented Apr 2, 2020 •

edited

Loading

tstromberg left a comment •

edited

Loading