Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error picking non-default alternate drivers #11371

Merged
merged 1 commit into from
May 18, 2021
Merged

Fix error picking non-default alternate drivers #11371

merged 1 commit into from
May 18, 2021

Conversation

afbjorklund
Copy link
Collaborator

We should not select drivers like "ssh" or "none",
unless explicitly requested by the user. Wrong var...

Fix small bug from PR #10554
When fixing issue from PR #7389

@afbjorklund
Fix error picking non-default alternate drivers
97b152f 
We should not select drivers like "ssh" or "none",
unless explicitly requested by the user. Wrong var...
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 11, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 11, 2021
@afbjorklund afbjorklund mentioned this pull request May 11, 2021
Closed
@ilya-zuyev ilya-zuyev self-requested a review May 11, 2021 20:23
ilya-zuyev
ilya-zuyev approved these changes May 11, 2021
View reviewed changes
Copy link
Contributor

@ilya-zuyev ilya-zuyev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ilya-zuyev
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 11, 2021
@k8s-ci-robot
Copy link
Contributor

@afbjorklund: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-minikube-build 97b152f link /test pull-minikube-build

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@medyagh
Copy link
Member

medyagh commented May 13, 2021

@afbjorklund needs a rebase plz

@medyagh medyagh self-requested a review May 13, 2021 19:08
@afbjorklund afbjorklund mentioned this pull request May 16, 2021
Merged
@medyagh medyagh merged commit cd73e83 into kubernetes:master May 18, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, ilya-zuyev, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [afbjorklund,ilya-zuyev,medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@afbjorklund afbjorklund mentioned this pull request May 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilya-zuyev ilya-zuyev ilya-zuyev approved these changes

@medyagh medyagh medyagh approved these changes

@blueelvis blueelvis Awaiting requested review from blueelvis

@prezha prezha Awaiting requested review from prezha

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@afbjorklund @ilya-zuyev @k8s-ci-robot @medyagh