Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log errors for unit test for TestGetOk/TestSetOK #6725

Merged
merged 6 commits into from
Feb 21, 2020
Merged

log errors for unit test for TestGetOk/TestSetOK #6725

merged 6 commits into from
Feb 21, 2020

Conversation

medyagh
Copy link
Member

@medyagh medyagh commented Feb 21, 2020 •
edited
Loading

  • add more logging to unit tests to help debug TestGetOK unit test failure #6711
  • improve the github actions by putting the lint in its own job and making the end result look better.
  • the github aciton upload all reports should proceed even if one upload fails

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 21, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2020
@medyagh medyagh changed the title add error wrpaps for config set log errors for unit test for TestGet Feb 21, 2020
@medyagh medyagh changed the title log errors for unit test for TestGet log errors for unit test for TestGetOk/TestSetOK Feb 21, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 21, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 21, 2020
@TravisBuddy
Copy link

Travis tests have failed

Hey @medyagh,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 19fa8420-5470-11ea-a42e-53e1226a9a7b

@medyagh medyagh merged commit 6eb9292 into kubernetes:master Feb 21, 2020
@medyagh medyagh deleted the testgetok branch May 2, 2020 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

@blueelvis blueelvis Awaiting requested review from blueelvis

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@medyagh @k8s-ci-robot @TravisBuddy