Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestGetOK unit test failure #6711

Closed
medyagh opened this issue Feb 20, 2020 · 1 comment · Fixed by #6726
Closed

TestGetOK unit test failure #6711

medyagh opened this issue Feb 20, 2020 · 1 comment · Fixed by #6726
Labels
kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test.

Comments

@medyagh
Copy link
Member

medyagh commented Feb 20, 2020

this unit test test fails on travis but not on my linux

--- FAIL: TestGetOK (0.00s)
    get_test.go:32: Set returned error for property vm-driver
--- FAIL: TestSetOK (0.00s)
    set_test.go:55: Set returned error for valid property value
    set_test.go:51: failed to unset vm-driver
--- FAIL: TestUnsetConfig (0.00s)
    unset_test.go:30: Failed to set the property "cpus"
    unset_test.go:35: Failed to read config "specified key could not be found in config"
    unset_test.go:39: Expected cpus to be 1 but got 
    unset_test.go:44: Failed to unset property "create /home/travis/.minikube/config/config.json: open /home/travis/.minikube/config/config.json: no such file or directory"
@medyagh medyagh mentioned this issue Feb 20, 2020
Merged
@medyagh medyagh added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Feb 20, 2020
@medyagh medyagh mentioned this issue Feb 21, 2020
Merged
@sayboras
Copy link
Contributor

@medyagh sorry, I didn't see your PR before, I fixed this in https://github.com/kubernetes/minikube/pull/6726/files

@sayboras sayboras mentioned this issue Feb 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix unit test sayboras/minikube
2 participants
@medyagh @sayboras