Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Included githubactions in dependabot config #13770

Merged

Conversation

naveensrinivasan
Copy link
Contributor

  • Included githubactions in the dependabot config
  • Included "ok-to-test" label as this avoids someone manually doing it.

- Included githubactions in the dependabot config
- Included "ok-to-test" label as this avoids someone manually doing it.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 12, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @naveensrinivasan!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 12, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @naveensrinivasan. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 12, 2022
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@naveensrinivasan
Copy link
Contributor Author

/assign @medyagh

@klaases
Copy link
Contributor

klaases commented Mar 14, 2022

Hi @medyagh, are you the correct assignee for merging this PR?

@naveensrinivasan
Copy link
Contributor Author

Hi @medyagh, are you the correct assignee for merging this PR?

@klaases I don't if @medyagh is the correct assignee. I just assigned because the bot recommended. If you have the powers could you please review it?

Thanks

@naveensrinivasan
Copy link
Contributor Author

Hi @medyagh, are you the correct assignee for merging this PR?

@klaases I don't if @medyagh is the correct assignee. I just assigned because the bot recommended. If you have the powers could you please review it?

Thanks

A friendly reminder

@naveensrinivasan
Copy link
Contributor Author

@prasadkatti / @prezha Could I please get some 👀 ?

@spowelljr
Copy link
Member

spowelljr commented Mar 23, 2022

Hi @naveensrinivasan, I'm happy to review this change, but I'm unfamiliar with what exactly this is doing. Would you mind explaining exactly what this is doing, what improvements it results in, and any links to documentation that I could read to help me understand this, thanks!

@naveensrinivasan
Copy link
Contributor Author

Hi @naveensrinivasan, I'm happy to review this change, but I'm unfamiliar with what exactly this is doing. Would you mind explaining exactly what this is doing, what improvements it results in, and any links to documentation that I could read to help me understand this, thanks!

@spowelljr Thank you! This should help with keeping the GitHub actions updated on new releases. This will also help with keeping it secure. I have included a few documents. My apologies for not including it. I work in supply chain security and didn't realize it is not that everyone is aware of the things I do.

Let me know if you want more information.

@spowelljr
Copy link
Member

@naveensrinivasan Thank you very much for the information, this looks good to me.

@spowelljr spowelljr merged commit 3ecfadb into kubernetes:master Mar 24, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: naveensrinivasan, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants