Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use docker buildx for the build-image. #99080

Merged
merged 1 commit into from
Jun 5, 2021
Merged

Use docker buildx for the build-image. #99080

merged 1 commit into from
Jun 5, 2021

Conversation

vinayakankugoyal
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Switch to using docker buildx for the build-image. We want to consistently use buildx everywhere as highlighted in #98908.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 14, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @vinayakankugoyal. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 14, 2021
@vinayakankugoyal
Copy link
Contributor Author

/cc @BenTheElder

@BenTheElder
Copy link
Member

We need to be ensuring a buildx builder exists, the first point in that issue needs fixing before this one.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 17, 2021
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 19, 2021
@vinayakankugoyal
Copy link
Contributor Author

/test pull-kubernetes-cross

@k8s-ci-robot
Copy link
Contributor

@vinayakankugoyal: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-kubernetes-cross

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vinayakankugoyal vinayakankugoyal mentioned this pull request Feb 19, 2021
Merged
@PurelyApplied
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 19, 2021
@vinayakankugoyal
Copy link
Contributor Author

/test pull-kubernetes-bazel-test

@vinayakankugoyal
Copy link
Contributor Author

/test pull-kubernetes-cross

@BenTheElder
Copy link
Member

/test all
/test pull-kubernetes-cross

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 12, 2021
@pacoxu
Copy link
Member

pacoxu commented Mar 17, 2021

1.21 or 1.22 ?

need rebase for conflicts.

@vinayakankugoyal
Copy link
Contributor Author

1.21 or 1.22 ?

Since code freeze for 1.21 is already in effect, 1.22.

@vinayakankugoyal
Copy link
Contributor Author

need rebase for conflicts.

Thanks Done!

@vinayakankugoyal
Copy link
Contributor Author

/test pull-kubernetes-unit

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 17, 2021
@vinayakankugoyal
Copy link
Contributor Author

@BenTheElder - do we wan't to make this change? I believe we are using buildx for docker builds for other images already.

BenTheElder
BenTheElder approved these changes Jun 4, 2021
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

buildx is already a hard requirement for building a Kubernetes release since at least v1.21.0

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2021
@BenTheElder
Copy link
Member

BenTheElder commented Jun 4, 2021 •
edited
Loading

/test pull-kubernetes-node-e2e-containerd

[new job that is stuck pending because it was added while this PR was inactive I think]

@vinayakankugoyal
Copy link
Contributor Author

pull-kubernetes-node-e2e-containerd passed, @BenTheElder can you /lgtm when you get a chance? Thanks!

@BenTheElder
Copy link
Member

bah, in some repos github approve is lgtm + approve with prow
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 4, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, vinayakankugoyal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BenTheElder
Copy link
Member

/triage accepted
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 4, 2021
@vinayakankugoyal
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit aaceb26 into kubernetes:master Jun 5, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 5, 2021
@ehashman ehashman mentioned this pull request Jun 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder approved these changes

@spiffxp spiffxp Awaiting requested review from spiffxp

Assignees

@BenTheElder BenTheElder

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.
7 participants
@vinayakankugoyal @k8s-ci-robot @BenTheElder @PurelyApplied @fejta @spiffxp @pacoxu