Create new metric which conform to our naming conventions

[jyz0309]

Signed-off-by: jyz0309 [email protected]

add comment

Signed-off-by: jyz0309 [email protected]

What type of PR is this?

/kind cleanup
/kind deprecation

What this PR does / why we need it:

According to the #103441 , we want to deprecate apiserver_longrunning_gauge and apiserver_register_watchers metrics and create a new one which actually does conform to our naming conventions probably something like apiserver_longrunning_requests.
And #103793 have deprecated metrics, and this pr will create a new metric to replace apiserver_longrunning_gauge and conform to our naming conventions.

Which issue(s) this PR fixes:

Fixes #103441

Special notes for your reviewer:

Does this PR introduce a user-facing change?

add apiserver_longrunning_requests metric to replace the soon to be deprecated apiserver_longrunning_gauge metric.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

[k8s-ci-robot]

Hi @jyz0309. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jyz0309]

/sig instrumentation

[jyz0309]

@jimmidyson @wojtek-t @logicalhan PTAL~

[fedebongio]

/assign @logicalhan
/triage accepted

[dgrisonnet]

@jyz0309 I think it would be great to add a release note to mention that the apiserver_longrunning_requests metric is replacing the soon to be deprecated apiserver_longrunning_gauge metric.

[dgrisonnet]

/ok-to-test

[jyz0309]

/retest-required

[jyz0309]

/retest-required

[dgrisonnet]

/lgtm

[jyz0309]

It seem that the relate pr has been merged.#103793 @dgrisonnet Can you help me merge this pr?

[dgrisonnet]

We would need an approver to move forward with this PR. @logicalhan can you have look?

[logicalhan]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jyz0309, logicalhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• staging/src/k8s.io/apiserver/pkg/endpoints/metrics/OWNERS [logicalhan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[alecgarza96]

Came across issues #102545 #103441 and a couple others referencing duplicate watch count metrics. These issues all seem to be linked, however, I am new to open source contributions. Are duplicate watch count metrics still an issue?

Based off my reading, it seems as if it was deemed to risky to remove the duplicates and instead they were chosen to be deprecated and a new standard implemented.

Essentially, I'd like to contribute to this issue, but I'm not sure what direction to move in.

Thank you