Deprecate apiserver_longrunning_gauge metric in favor of apiserver_longrunning_requests #14856
Conversation
ghost
added
the
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
| @@ -62,6 +63,8 @@ | |||
| # https://kubernetes.io/docs/reference/using-api/deprecation-policy/#rest-resources-aka-api-objects | |||
| 'apiserver_requested_deprecated_apis': 'requested_deprecated_apis', | |||
| # For Kubernetes >= 1.23 | |||
| # https://github.com/kubernetes/kubernetes/pull/103799 | |||
| 'apiserver_longrunning_requests': 'longrunning_requests', | |||
There was a problem hiding this comment.
usually we try to remap the new metrics name to the previous name, to ease the life of users (they don't need to update their dashboards or monitors)
If the new metric return exactly the same value (unit) and is expose with the same type (here gauge), we can remap the metric to the previous name.
if the unit change, we can use a transformer function to comeback to the previous unit. (when it makes sens)
| 'apiserver_longrunning_requests': 'longrunning_requests', | |
| 'apiserver_longrunning_requests': 'longrunning_gauge', |
There was a problem hiding this comment.
@clamoriniere what happens in the case for Kubernetes versions (like 1.23) that had both metrics (the deprecated one, and the new one)
There was a problem hiding this comment.
So the last applied will override the other. which is fine since the value should be equal
|
The |
arapulido
force-pushed
the
ara.pulido/deprecate_longrunning_gauge
branch
from
ad7731c to
191452d
Compare
…ngrunning_requests (#14856) * Deprecate apiserver_longrunning_gauge in favor of apiserver_longrunning_requests * Add longrunning_requests metric to the metadata * Override the longrunning_gauge metric for backwards compatibility * Fix metadata validation * fix tests * Fix metadata
|
Is this only going to be fixed in Agent version 7.47.0? Thank you |
|
hi @therc Yes in the next agent release so |
What does this PR do?
kube_apiserver metric
longrunning_gaugehas been deprecated since 1.23 in favor oflongrunning_requests.See PR: kubernetes/kubernetes#103799
More over, the deprecated metric was fully removed in 1.25 https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.25.md#other-cleanup-or-flake-2
This is also a metric that we use in the OOTB dashboard, so this dashboard has an empty widget for all customers running >= 1.25
Motivation
Additional Notes
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attachedqa/skip-qalabel.