Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update skew change in v1.29 from n-1 to n-3 #2950

Closed
wants to merge 1 commit into from
Closed

Update skew change in v1.29 from n-1 to n-3 #2950

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions kinder/ci/kubeadm-periodic.tests.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,11 @@ Workflow file names: [`skew-[x]-on-[y]`](./workflows)
Kubelet X on Y tests are meant to verify the proper functioning of a version X kubelet against version Y (X+1 or X+2)
kubeadm and control plane. The coverage of X == Y is already covered by the `regular-*` tests.

Note that for the time being kubeadm version X does not support skew against a kubelet version X-2,
similarly to how kubeadm does not support X-2 skew with the control plane. This requires skipping
the `KubeletVersion` preflight check. In the future if these X-2 tests are no longer possible with kubeadm
they would have to be adapted on the kinder side or dropped.
Before kubeadm v1.29, the maximum kubelet skew from the kubeadm version was X-1. This required skipping
the KubeletVersion preflight check.

After kubeadm v1.29, the maximum kubelet skew from the kubeadm version has become X-3 and KubeletVersion
preflight check no longer has to be skipped.
Comment on lines +74 to +78
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Before kubeadm v1.29, the maximum kubelet skew from the kubeadm version was X-1. This required skipping
the KubeletVersion preflight check.
After kubeadm v1.29, the maximum kubelet skew from the kubeadm version has become X-3 and KubeletVersion
preflight check no longer has to be skipped.
Before kubeadm v1.29, the maximum kubeadm / kubelet skew was X-1. For example, kubeadm v1.28 could deploy a kubelet that is v1.28 or v1.27. After v1.29 the maximum skew has become X-3. For example, kubeadm v1.29 can deploy a kubelet that is as old as v1.26.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So here deploy means init/upgrade/join operations. This is clear. Updated.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So here deploy means init/upgrade/join operations. This is clear. Updated.

i don't see a new commit?


Workflow file names: [`skew-kubelet-[x]-on-[y]`](./workflows)

Expand Down