Update skew change in v1.29 from n-1 to n-3 #2950
Conversation
- preflight check KubeletVersion behavior change
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pacoxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
There was a problem hiding this comment.
reworded the comment a little.
please check if you agree and if it's correct.
we need to update this k/website page as well.
https://kubernetes.io/docs/setup/production-environment/tools/kubeadm/create-cluster-kubeadm/#kubeadm-s-skew-against-the-kubelet
(dev-1.29 branch)
| Before kubeadm v1.29, the maximum kubelet skew from the kubeadm version was X-1. This required skipping | ||
| the KubeletVersion preflight check. | ||
|
|
||
| After kubeadm v1.29, the maximum kubelet skew from the kubeadm version has become X-3 and KubeletVersion | ||
| preflight check no longer has to be skipped. |
There was a problem hiding this comment.
| Before kubeadm v1.29, the maximum kubelet skew from the kubeadm version was X-1. This required skipping | |
| the KubeletVersion preflight check. | |
| After kubeadm v1.29, the maximum kubelet skew from the kubeadm version has become X-3 and KubeletVersion | |
| preflight check no longer has to be skipped. | |
| Before kubeadm v1.29, the maximum kubeadm / kubelet skew was X-1. For example, kubeadm v1.28 could deploy a kubelet that is v1.28 or v1.27. After v1.29 the maximum skew has become X-3. For example, kubeadm v1.29 can deploy a kubelet that is as old as v1.26. |
There was a problem hiding this comment.
So here deploy means init/upgrade/join operations. This is clear. Updated.
There was a problem hiding this comment.
So here
deploymeansinit/upgrade/joinoperations. This is clear. Updated.
i don't see a new commit?
|
/skip |
Opened kubernetes/website#43769 |
|
I mistakenly created a new branch in kubeadm. I recreate a new PR in #2953 |
|
Could you help to remove two branches in the repo with |
i will clean them |
Only change the comments here.
Leave the remove of the KubeletVersion from ignorePreflightErrors to v1.32 when all skew CI can remove it.