Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm-1.10 does not cleanup pods in CRI-O with recent crictl versions #748

Closed
kars7e opened this issue Apr 9, 2018 · 7 comments · Fixed by kubernetes/kubernetes#63862
Closed

kubeadm-1.10 does not cleanup pods in CRI-O with recent crictl versions #748

kars7e opened this issue Apr 9, 2018 · 7 comments · Fixed by kubernetes/kubernetes#63862
Assignees
@runcom
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@kars7e
Copy link

kars7e commented Apr 9, 2018

What happened?

Recent version of crictl introduced new syntax for retreiving/cleaning pods. Crictl subcommands previously known as sandboxes, stops and rms, are now pods, stopp and rmp, respectively. This causes a failure when running kubeadm reset with latest crictl(crictl-v1.0.0-beta):

[reset] Cleaning up running containers using crictl with socket /var/run/crio/crio.sock
[reset] Failed to list running pods using crictl. Trying using docker instead.

What you expected to happen?

Pods in CRI-O to be properly cleaned up.

How to reproduce it (as minimally and precisely as possible)?

Use latest cri-tools and kubeadm-v1.10.0 and try running kubeadm reset

Anything else we need to know?

I'm wondering if it would be more future-proof if kubeadm used k8s.io/kubernetes/pkg/kubelet/apis/cri/runtime/v1alpha2 directly instead of relying on CLI tool, it would be easier to ensure compatible API (currently, it's up to the user to install compatible version of crictl)

Versions

kubeadm version (use kubeadm version):

kubeadm version: &version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.0", GitCommit:"fc32d2f3698e36b93322a3465f63a14e9f0eaead", GitTreeState:"clean", BuildDate:"2018-03-26T16:44:10Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"linux/arm"}

Environment:

  • Kubernetes version (use kubectl version):
  • Cloud provider or hardware configuration: ARM (Tinkerboard)
  • OS (e.g. from /etc/os-release):
NAME="Ubuntu"
VERSION="16.04.4 LTS (Xenial Xerus)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 16.04.4 LTS"
VERSION_ID="16.04"
HOME_URL="http://www.ubuntu.com/"
SUPPORT_URL="http://help.ubuntu.com/"
BUG_REPORT_URL="http://bugs.launchpad.net/ubuntu/"
VERSION_CODENAME=xenial
UBUNTU_CODENAME=xenial
  • Kernel (e.g. uname -a): Linux tinker-0 4.14.29-rockchip #1 SMP PREEMPT Sat Mar 24 21:55:01 PDT 2018 armv7l armv7l armv7l GNU/Linux
  • Others:
@timothysc timothysc added kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed priority/backlog Higher priority than priority/awaiting-more-evidence. labels Apr 10, 2018
@timothysc
Copy link
Member

/cc @jberkus @runcom for routing.

@kars7e for completeness you are running kubeadm on arm with CRI-O on ubunutu?

@timothysc timothysc added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. and removed priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Apr 10, 2018
@runcom
Copy link

runcom commented Apr 10, 2018

I'm going to fix this

@kars7e
Copy link
Author

kars7e commented Apr 11, 2018

Thanks @runcom !

@timothysc yes, it's ubuntu 16.04 on ARM architecture, with CRI-O version 1.10.0 from https://launchpad.net/~projectatomic/+archive/ubuntu/ppa, and crictl from https://github.com/kubernetes-incubator/cri-tools/releases/download/v1.0.0-beta.0/crictl-v1.0.0-beta.0-linux-arm.tar.gz

@timothysc timothysc mentioned this issue Apr 11, 2018
Closed
@timothysc
Copy link
Member

/assign @runcom

@timothysc timothysc added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. labels Apr 11, 2018
This was referenced May 8, 2018
Merged
Closed
@runcom
Copy link

runcom commented May 15, 2018

@kars7e could you test with latest code?

@runcom runcom mentioned this issue May 15, 2018
Merged
@kars7e
Copy link
Author

kars7e commented May 15, 2018

@runcom Sure thing. Is there any specific released binary I should test, or should I build from latest master (including #63862)?

@runcom
Copy link

runcom commented May 16, 2018

latest master + that PR :)

k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this issue May 24, 2018
Merge pull request #63862 from runcom/fix-reset-crictl
42d6567 
Automatic merge from submit-queue (batch tested with PRs 62756, 63862, 61419, 64015, 64063). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

kubeadm: crictl reset commands fixes

Signed-off-by: Antonio Murdaca <[email protected]>



**What this PR does / why we need it**:

change container stop/rm commands with sandbox stop/rm to properly reset using kubeadm

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes kubernetes/kubeadm#748

**Special notes for your reviewer**:

**Release note**:

```release-note
Correct the way we reset containers and pods in kubeadm via crictl
```
@bergwolf bergwolf mentioned this issue Jul 31, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@runcom runcom

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

kubeadm: crictl reset commands fixes runcom/kubernetes
3 participants
@timothysc @runcom @kars7e