Rename sandbox to podsandbox.
#222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lantao Liu <[email protected]>
k8s-ci-robot
added
cncf-cla: yes
|
/lgtm |
k8s-ci-robot
added
the
lgtm
miaoyq
reviewed
Jan 11, 2018
| @@ -147,8 +147,8 @@ var podSandboxStatusCommand = cli.Command{ | |||
| } | |||
|
|
|||
| var listPodSandboxCommand = cli.Command{ | |||
| Name: "sandboxes", | |||
| Usage: "List sandboxes", | |||
| Name: "pods", | |||
There was a problem hiding this comment.
This command will be frequently used, I feel like podsandboxes is too long, which will be very annoying in the future. :P
That's why I use crictl pods for this command.
|
@Random-Liu I was expecting full replacement of sandbox for pod, not sandbox to pod sandbox in some cases? Might be wrong but I thought the point was only internal developers of kublet know what sandbox refers to. |
|
@mikebrow I think at CRI level pod = However, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is discussed in sig-node. I sent the PR here to carry on the discussion.
The rule I used in this PR:
s->p, andsandbox->pod;SANDBOX->PODSANDBOX;sandbox-config.yaml->podsandbox-config.yaml;--sandbox->--podsandboxsandbox->pod sandbox.Note: This is a breaking change. We may want to emphasize this in release note. And after upgrade, we need to change all places which use
crictl, including cri-containerd, cri-o, kubeadm etc.@yujuhong @feiskyer @runcom @mrunalp @mikebrow @abhi @yanxuean @miaoyq @dchen1107
Signed-off-by: Lantao Liu [email protected]