Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update API slice fields to not use pointers #9802

Merged
merged 1 commit into from
Aug 24, 2020
Merged

Update API slice fields to not use pointers #9802

merged 1 commit into from
Aug 24, 2020

Conversation

rifelpet
Copy link
Member

A slice of pointers causes problems with the Kubernetes 1.19 code-generator.

A nil entry in these slices isn't valid anyways, so this should have no impact short of being a breaking change for anyone importing these API types.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 23, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2020
@rifelpet
Copy link
Member Author

/hold for comment

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 23, 2020
@johngmyers
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 23, 2020
@rifelpet rifelpet mentioned this pull request Aug 24, 2020
Merged
@rifelpet
Copy link
Member Author

/test pull-kops-e2e-k8s-containerd

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 24, 2020
@rifelpet
Copy link
Member Author

/test pull-kops-e2e-k8s-containerd

@rifelpet rifelpet force-pushed the api-slice-pointers branch from 079718b to ca790db Compare August 24, 2020 03:23
@rifelpet
Copy link
Member Author

/test pull-kops-e2e-k8s-containerd

@rifelpet rifelpet force-pushed the api-slice-pointers branch from ca790db to 2b39b42 Compare August 24, 2020 03:30
@rifelpet
Copy link
Member Author

/test pull-kops-e2e-k8s-containerd

@rifelpet rifelpet force-pushed the api-slice-pointers branch from 2b39b42 to bffa68a Compare August 24, 2020 03:48
@k8s-ci-robot k8s-ci-robot added the area/provider/aws Issues or PRs related to aws provider label Aug 24, 2020
@rifelpet
Copy link
Member Author

/test pull-kops-e2e-k8s-containerd

@olemarkus
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 24, 2020
hakman
hakman requested changes Aug 24, 2020
View reviewed changes
Copy link
Member

@hakman hakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think using a pointer to a slice member would reduce the number of changes.

pkg/model/components/etcdmanager/options.go Outdated Show resolved Hide resolved
pkg/model/components/etcd.go Outdated Show resolved Hide resolved
pkg/model/awsmodel/autoscalinggroup.go Outdated Show resolved Hide resolved
@rifelpet rifelpet force-pushed the api-slice-pointers branch from bffa68a to e57045b Compare August 24, 2020 12:23
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 24, 2020
@rifelpet
Copy link
Member Author

Updated to use pointers when modifying elements in a for loop. diff looks much cleaner now 👍
I'll wait for #9803 to merge before rebasing once more. just to confirm the containerd e2e job still passes.

@rifelpet
Update API slice fields to not use pointers
7d9f0a0 
This is causing problems with the Kubernetes 1.19 code-generator.
A nil entry in these slices wouldn't be valid anyways, so this should have no impact.
@rifelpet rifelpet force-pushed the api-slice-pointers branch from e57045b to 7d9f0a0 Compare August 24, 2020 12:46
@rifelpet
Copy link
Member Author

/hold cancel
/test pull-kops-e2e-k8s-containerd

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 24, 2020
@hakman
Copy link
Member

hakman commented Aug 24, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 24, 2020
@hakman
Copy link
Member

hakman commented Aug 24, 2020

/test pull-kops-e2e-kubernetes-aws

@rifelpet
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 255e48a into kubernetes:master Aug 24, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Aug 24, 2020
@rifelpet rifelpet deleted the api-slice-pointers branch October 29, 2020 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman requested changes

@gjtempleton gjtempleton Awaiting requested review from gjtempleton

@rdrgmnzs rdrgmnzs Awaiting requested review from rdrgmnzs

Assignees

@olemarkus olemarkus

@johngmyers johngmyers

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
5 participants
@rifelpet @k8s-ci-robot @johngmyers @olemarkus @hakman