-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade kubernetes dependencies to 1.19.0-rc.4 #9565
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@rifelpet tomorrow should be a .rc1 release. Should we wait for it. Many things were blocked from entering .rc0. |
sounds good to me. ill use this as a sandbox to get the builds working with the updated deps and then update it to rc.1 when it is released. |
Sounds perfect |
56f2f63
to
b9dd540
Compare
some troubleshooting notes: There are failures anytime the apimachinery code is exercised:
The error is always for EtcdClusterSpec (though its possible if we fix it then we'll get an error for the next impacted field). This seems to be related to kubernetes/kubernetes#90018 We're also getting interface type errors for logr which is used by klog. This seems to fix it but will need to be merged and propagated go-logr/logr#20 otherwise we're in a bit of a dependency mess until all our deps update to the newer version of logr. lastly theres a github.com/googleapis/gnostic case change that was a pain to update on my case-insensitive mac: google/gnostic#157 |
b164e4e
to
f4b1e46
Compare
6877b91
to
e496d55
Compare
🎉 |
@rifelpet: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/hold for #9802 to merge |
/hold cancel this is ready to go |
/lgtm |
Just in time for the 1.19.0 k8s release tomorrow :) so much for the head start |
/lgtm |
This is a find/replace of
v0.18.1
tov0.19.0-rc.2
in go.mod and then runningmake gomod