Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade kubernetes dependencies to 1.19.0-rc.4 #9565

Merged
merged 3 commits into from
Aug 24, 2020

Conversation

rifelpet
Copy link
Member

@rifelpet rifelpet commented Jul 13, 2020

This is a find/replace of v0.18.1 to v0.19.0-rc.2 in go.mod and then running make gomod

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 13, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2020
@rifelpet rifelpet changed the title Upgrade kubernetes dependencies to 1.19.0-rc.0 WIP Upgrade kubernetes dependencies to 1.19.0-rc.0 Jul 13, 2020
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 13, 2020
@hakman
Copy link
Member

hakman commented Jul 13, 2020

@rifelpet tomorrow should be a .rc1 release. Should we wait for it. Many things were blocked from entering .rc0.

@rifelpet
Copy link
Member Author

sounds good to me. ill use this as a sandbox to get the builds working with the updated deps and then update it to rc.1 when it is released.

@hakman
Copy link
Member

hakman commented Jul 13, 2020

Sounds perfect

@rifelpet rifelpet force-pushed the k-119 branch 2 times, most recently from 56f2f63 to b9dd540 Compare July 13, 2020 21:34
@rifelpet
Copy link
Member Author

some troubleshooting notes:

There are failures anytime the apimachinery code is exercised:

TestCreateClusterWithINGWSpecified: create_cluster_integration_test.go:191: error running create cluster: error writing updated configuration: error writing Cluster "private.example.com": error marshaling object: error encoding object: converting (*kops.EtcdClusterSpec) to (*v1alpha2.EtcdClusterSpec): unknown conversion

The error is always for EtcdClusterSpec (though its possible if we fix it then we'll get an error for the next impacted field). This seems to be related to kubernetes/kubernetes#90018


We're also getting interface type errors for logr which is used by klog. This seems to fix it but will need to be merged and propagated go-logr/logr#20 otherwise we're in a bit of a dependency mess until all our deps update to the newer version of logr.


lastly theres a github.com/googleapis/gnostic case change that was a pain to update on my case-insensitive mac: google/gnostic#157

@rifelpet rifelpet force-pushed the k-119 branch 2 times, most recently from b164e4e to f4b1e46 Compare July 14, 2020 20:16
@rifelpet rifelpet changed the title WIP Upgrade kubernetes dependencies to 1.19.0-rc.0 WIP Upgrade kubernetes dependencies to 1.19.0-rc.1 Jul 14, 2020
@rifelpet rifelpet changed the title WIP Upgrade kubernetes dependencies to 1.19.0-rc.1 WIP Upgrade kubernetes dependencies to 1.19.0-rc.2 Jul 21, 2020
@k8s-ci-robot k8s-ci-robot added area/api area/channels area/kops-controller area/nodeup area/provider/alicloud Issues or PRs related to alicloud provider area/provider/aws Issues or PRs related to aws provider area/provider/digitalocean Issues or PRs related to digitalocean provider area/provider/openstack Issues or PRs related to openstack provider labels Jul 28, 2020
@rifelpet rifelpet force-pushed the k-119 branch 6 times, most recently from 6877b91 to e496d55 Compare August 24, 2020 01:58
@rifelpet
Copy link
Member Author

🎉
/test pull-kops-e2e-k8s-containerd

@k8s-ci-robot
Copy link
Contributor

@rifelpet: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kops-e2e-k8s-containerd e496d55 link /test pull-kops-e2e-k8s-containerd

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rifelpet rifelpet changed the title WIP Upgrade kubernetes dependencies to 1.19.0-rc.4 Upgrade kubernetes dependencies to 1.19.0-rc.4 Aug 24, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 24, 2020
@rifelpet
Copy link
Member Author

/hold for #9802 to merge

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 24, 2020
@rifelpet
Copy link
Member Author

/hold cancel

this is ready to go

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 24, 2020
@olemarkus
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 24, 2020
@rifelpet
Copy link
Member Author

rifelpet commented Aug 24, 2020

Just in time for the 1.19.0 k8s release tomorrow :) so much for the head start

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 24, 2020
@hakman
Copy link
Member

hakman commented Aug 24, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 24, 2020
@k8s-ci-robot k8s-ci-robot merged commit b3721f9 into kubernetes:master Aug 24, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api area/channels area/documentation area/kops-controller area/nodeup area/provider/alicloud Issues or PRs related to alicloud provider area/provider/aws Issues or PRs related to aws provider area/provider/digitalocean Issues or PRs related to digitalocean provider area/provider/openstack Issues or PRs related to openstack provider area/provider/spotinst Issues or PRs related to spotinst provider area/rolling-update cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants