Update protobuf to v1.4.2 #9686
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
/cc @rifelpet |
k8s-ci-robot
added
the
size/XXL
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
hakman
force-pushed
the
update-protobuf
branch
3 times, most recently
from
f54f0de to
7350091
Compare
| @@ -166,7 +166,7 @@ codegen: kops-gobindata | |||
|
|
|||
| .PHONY: protobuf | |||
| protobuf: | |||
| cd ${GOPATH_1ST}/src; protoc --gofast_out=. k8s.io/kops/protokube/pkg/gossip/mesh/mesh.proto | |||
There was a problem hiding this comment.
could we have this run ./hack/update-header.sh afterwards, rather than ignoring the file in hack/verify-boilerplate.sh ?
and maybe something similar with gofmt below
There was a problem hiding this comment.
I don't think there is a huge value in having the copyright in this file.
In general, would be best to leave this as untouched as possible including by gofmt. In the future, it will be easier to understand the changes. I am tempted to make a PR for gogo/protobuf and fix the gofmt issue there.
| github.com/golang/protobuf v1.3.3 h1:gyjaxf+svBWX08ZjK86iN9geUJF0H6gp2IRKX6Nf6/I= | ||
| github.com/golang/protobuf v1.3.3/go.mod h1:vzj43D7+SQXF/4pzW/hwtAqwc6iTitCiVSaWz5lYuqw= | ||
| github.com/golang/protobuf v1.4.0-rc.1/go.mod h1:ceaxUfeHdC40wWswd/P6IGgMaK3YpKi5j83Wpe3EHw8= | ||
| github.com/golang/protobuf v1.4.0-rc.1.0.20200221234624-67d41d38c208/go.mod h1:xKAWHe0F5eneWXFV3EuXVDTCmh+JuBKY0li0aMyXATA= |
There was a problem hiding this comment.
Isn't it part of make gomod now?
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Prerequisite for #9565.