Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add k8s-artifacts-cri-tools prod push bucket and IAM group #908

Merged
merged 1 commit into from
May 28, 2020
Merged

Add k8s-artifacts-cri-tools prod push bucket and IAM group #908

merged 1 commit into from
May 28, 2020

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented May 28, 2020 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 28, 2020
@k8s-ci-robot k8s-ci-robot requested review from dims and spiffxp May 28, 2020 03:33
justaugustus
justaugustus commented May 28, 2020
View reviewed changes
groups/groups.yaml Outdated
@@ -318,23 +319,32 @@ groups:
settings:
ReconcileMembers: "true"
members:
- [email protected]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not directly related to CRI tools. Just doing it as a cleanup since I was already in the file.

@justaugustus
Copy link
Member Author

The current IAM group does not include everyone from https://github.com/kubernetes-sigs/cri-tools/blob/master/OWNERS, simply because I don't have their email addresses on hand.

Happy to add them here once I do or we can address that as a follow-up.

@justaugustus justaugustus mentioned this pull request May 28, 2020
Closed
saschagrunert
saschagrunert approved these changes May 28, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thank you for addressing this, @justaugustus 🙏 !

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2020
feiskyer
feiskyer approved these changes May 28, 2020
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2020
@justaugustus justaugustus mentioned this pull request May 28, 2020
Merged
@dims
Copy link
Member

dims commented May 28, 2020

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, feiskyer, justaugustus, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2020
@k8s-ci-robot k8s-ci-robot merged commit cf9c731 into kubernetes:master May 28, 2020
@justaugustus justaugustus mentioned this pull request May 28, 2020
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@feiskyer feiskyer feiskyer approved these changes

@dims dims Awaiting requested review from dims

@spiffxp spiffxp Awaiting requested review from spiffxp

Assignees

@dims dims

@feiskyer feiskyer

@saschagrunert saschagrunert

@cblecker cblecker

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@justaugustus @dims @k8s-ci-robot @feiskyer @saschagrunert @cblecker @thockin