Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Cloud Bucket change for cri-tools #896

Closed
saschagrunert opened this issue May 26, 2020 · 8 comments
Closed

Google Cloud Bucket change for cri-tools #896

saschagrunert opened this issue May 26, 2020 · 8 comments
Assignees
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release.

Comments

@saschagrunert
Copy link
Member

saschagrunert commented May 26, 2020

The cri-tools update PR to v1.18.0 (kubernetes/kubernetes#91239) got reverted because I changed the download URL to point to GitHub, which caused an API rate limit hit. The main reason to change that URL was that release managers (and myself, even as maintainer of cri-tools) do not have the right set of permissions to upload the cri-tools artifacts to that bucket.

The bucket where ctictl was originally downloaded is kubernetes-release/crictl: https://console.cloud.google.com/storage/browser/kubernetes-release/crictl

The idea is to use the new gh2gc tool in kubernetes-release, so that release managers can upload the binary to a bucket which can be accessed by every release manager. This way we could use kubepkg to also build the artifacts (basically tarballs) and upload them in one command.

/cc @feiskyer @justaugustus

@justaugustus
Copy link
Member

/assign @justaugustus @saschagrunert
/sig release
/area release-eng

@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. area/release-eng Issues or PRs related to the Release Engineering subproject labels May 26, 2020
@justaugustus
Copy link
Member

justaugustus commented May 26, 2020

cc: @dims (who was on today's RelEng call)

@justaugustus
Copy link
Member

Opened a PR here to add the new bucket: #908
cc: @thockin (since he's been working on the other push buckets)

@justaugustus
Copy link
Member

The idea is to use the new gh2gcs tool in kubernetes-release, so that release managers can upload the binary to a bucket which can be accessed by every release manager. This way we could use kubepkg to also build the artifacts (basically tarballs) and upload them in one command.

@saschagrunert -- To clarify, cri-tools maintainers will still need to use whatever mechanisms are in place today to package tarballs for their releases. There will be a config in k/release hooked up to a Prow job to upload their releases to the new bucket.

kubepkg will then eventually be used to package the cri-tools during the k/k release process. This may change in the future, but today, creating tarballs is not an intended kubepkg feature.

@saschagrunert
Copy link
Member Author

Alright thanks for the clarification.

@feiskyer
Copy link
Member

Thanks @saschagrunert @justaugustus for moving this forward.

@justaugustus
Copy link
Member

For sure! #908 has merged and the bucket has been created, so we're done from the k/k8s.io perspective (thanks @dims!).

I've opened kubernetes-sigs/cri-tools#616 to continue tracking this from the k-sigs/cri-tools project instead.

/close

@k8s-ci-robot
Copy link
Contributor

@justaugustus: Closing this issue.

In response to this:

For sure! #908 has merged and the bucket has been created, so we're done from the k/k8s.io perspective (thanks @dims!).

I've opened kubernetes-sigs/cri-tools#616 to continue tracking this from the k-sigs/cri-tools project instead.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release.
Projects
None yet
Development

No branches or pull requests

4 participants