-
Notifications
You must be signed in to change notification settings - Fork 832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Cloud Bucket change for cri-tools #896
Comments
/assign @justaugustus @saschagrunert |
cc: @dims (who was on today's RelEng call) |
@saschagrunert -- To clarify, cri-tools maintainers will still need to use whatever mechanisms are in place today to package tarballs for their releases. There will be a config in k/release hooked up to a Prow job to upload their releases to the new bucket.
|
Alright thanks for the clarification. |
Thanks @saschagrunert @justaugustus for moving this forward. |
For sure! #908 has merged and the bucket has been created, so we're done from the k/k8s.io perspective (thanks @dims!). I've opened kubernetes-sigs/cri-tools#616 to continue tracking this from the k-sigs/cri-tools project instead. /close |
@justaugustus: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The cri-tools update PR to v1.18.0 (kubernetes/kubernetes#91239) got reverted because I changed the download URL to point to GitHub, which caused an API rate limit hit. The main reason to change that URL was that release managers (and myself, even as maintainer of cri-tools) do not have the right set of permissions to upload the cri-tools artifacts to that bucket.
The bucket where
ctictl
was originally downloaded iskubernetes-release/crictl
: https://console.cloud.google.com/storage/browser/kubernetes-release/crictlThe idea is to use the new gh2gc tool in kubernetes-release, so that release managers can upload the binary to a bucket which can be accessed by every release manager. This way we could use
kubepkg
to also build the artifacts (basically tarballs) and upload them in one command./cc @feiskyer @justaugustus
The text was updated successfully, but these errors were encountered: