Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kops: Bump terraform providers and modules for the build cluster. #7036

Merged
merged 1 commit into from
Jul 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions infra/aws/terraform/kops-infra-ci/eks.tf
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ limitations under the License.
module "eks" {
providers = { aws = aws.kops-infra-ci }
source = "terraform-aws-modules/eks/aws"
version = "20.8.3"
version = "20.10.0"
Copy link
Contributor

@bryantbiggs bryantbiggs Jul 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason not to go up to 20.20.0?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need the latest version but happy to do it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave it to you - but if this is Karpenter motivated, I would go to at least 20.15.0

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this cluster, there is no real need to switch to Karpenter right now. Probably something to think about in 2025.


cluster_name = local.cluster_name
cluster_version = var.eks_version
Expand Down Expand Up @@ -90,7 +90,6 @@ module "eks" {
capacity_type = "ON_DEMAND"
instance_types = ["r6id.2xlarge"]
ami_type = "BOTTLEROCKET_x86_64"
platform = "bottlerocket"

ebs_optimized = true
enable_monitoring = true
Expand Down
2 changes: 1 addition & 1 deletion infra/aws/terraform/kops-infra-ci/terraform.tf
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ terraform {
required_providers {
aws = {
source = "hashicorp/aws"
version = "~> 5.40.0"
version = "~> 5.58.0"
}
}
}