Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kops: Bump terraform providers and modules for the build cluster. #7036

Merged
merged 1 commit into from
Jul 19, 2024
Merged

kops: Bump terraform providers and modules for the build cluster. #7036

merged 1 commit into from
Jul 19, 2024
+2 −3

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Jul 19, 2024

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/infra Infrastructure management, infrastructure design, code in infra/ area/infra/aws Issues or PRs related to Kubernetes AWS infrastructure sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Jul 19, 2024
@k8s-ci-robot k8s-ci-robot requested review from dims and upodroid July 19, 2024 19:07
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 19, 2024
@ameukam
Copy link
Member Author

ameukam commented Jul 19, 2024

cc @bryantbiggs

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2024
bryantbiggs
bryantbiggs reviewed Jul 19, 2024
View reviewed changes
infra/aws/terraform/kops-infra-ci/eks.tf
@@ -17,7 +17,7 @@ limitations under the License.
module "eks" {
providers = { aws = aws.kops-infra-ci }
source = "terraform-aws-modules/eks/aws"
version = "20.8.3"
version = "20.10.0"
Copy link
Contributor

@bryantbiggs bryantbiggs Jul 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason not to go up to 20.20.0?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need the latest version but happy to do it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave it to you - but if this is Karpenter motivated, I would go to at least 20.15.0

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this cluster, there is no real need to switch to Karpenter right now. Probably something to think about in 2025.

@bryantbiggs
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

@bryantbiggs: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 19, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit cdd5f66 into kubernetes:main Jul 19, 2024
3 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Jul 19, 2024
@ameukam
Copy link
Member Author

ameukam commented Jul 23, 2024

@bryantbiggs I got

│ Error: updating EKS Node Group (k8s-infra-kops-prow-build:prow-build-20231205235350132400000001) version: operation error EKS: UpdateNodegroupVersion, https response error StatusCode: 400, RequestID: cc844a55-f471-43ab-9900-16b33e4faa3a, InvalidRequestException: 'k8s.io/cluster-autoscaler/k8s-infra-kops-prow-build' is not a valid tag key. Tag keys must match pattern ([0-9a-zA-Z\\-_+=,.@:]{1,255}), and must not be a reserved name ('.', '..', '_index')

but I'm sure the tags didn't change.

@bryantbiggs
Copy link
Contributor

it might be new validation that MNG is doing - we shouldn't need to add these tags per aws/containers-roadmap#608 (comment)

@bryantbiggs bryantbiggs mentioned this pull request Jul 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryantbiggs bryantbiggs bryantbiggs left review comments

@upodroid upodroid upodroid approved these changes

@dims dims Awaiting requested review from dims

Assignees

@upodroid upodroid

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/infra/aws Issues or PRs related to Kubernetes AWS infrastructure area/infra Infrastructure management, infrastructure design, code in infra/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.
4 participants
@ameukam @bryantbiggs @k8s-ci-robot @upodroid