Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync CAPZ owners with Azure provider project #3741

Merged
merged 1 commit into from
May 17, 2022
Merged

Sync CAPZ owners with Azure provider project #3741

merged 1 commit into from
May 17, 2022

Conversation

mboersma
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 17, 2022
@k8s-ci-robot k8s-ci-robot requested a review from jsturtevant May 17, 2022 22:41
@k8s-ci-robot k8s-ci-robot added the area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects label May 17, 2022
@k8s-ci-robot k8s-ci-robot requested a review from juan-lee May 17, 2022 22:41
@k8s-ci-robot k8s-ci-robot added area/k8s.gcr.io Code in k8s.gcr.io/ area/provider/azure Issues or PRs related to azure provider sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels May 17, 2022
@mboersma mboersma force-pushed the sync-capz-maintainers-2 branch from aa17a00 to 296157f Compare May 17, 2022 22:52
cpanato
cpanato approved these changes May 17, 2022
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2022
@mboersma
Copy link
Contributor Author

/assign @CecileRobertMichon @shysank

@mboersma mboersma force-pushed the sync-capz-maintainers-2 branch from 296157f to 74d19f2 Compare May 17, 2022 23:19
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels May 17, 2022
@mboersma
Copy link
Contributor Author

I removed "Jont828" to unblock this PR, but we will follow up and add him when k8s.io membership is approved.

CecileRobertMichon
CecileRobertMichon reviewed May 17, 2022
View reviewed changes
Copy link
Member

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, cpanato, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2022
@k8s-ci-robot k8s-ci-robot merged commit 0c073c5 into kubernetes:main May 17, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone May 17, 2022
@mboersma mboersma deleted the sync-capz-maintainers-2 branch May 17, 2022 23:24
@mboersma mboersma mentioned this pull request May 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CecileRobertMichon CecileRobertMichon CecileRobertMichon left review comments

@cpanato cpanato cpanato approved these changes

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

@juan-lee juan-lee Awaiting requested review from juan-lee

Assignees

@cpanato cpanato

@CecileRobertMichon CecileRobertMichon

@shysank shysank

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/k8s.gcr.io Code in k8s.gcr.io/ area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.
5 participants
@mboersma @k8s-ci-robot @cpanato @CecileRobertMichon @shysank