-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Jont828 as a CAPZ reviewer #3783
Conversation
Um...kubernetes/org#3156 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@mboersma kubernetes/org#3156 added @Jont828 to kubernetes-sigs, not kubernetes. @Jont828 you need to open a separate issue in https://github.com/kubernetes/org to request that you kubernetes-sigs membership be transferred to kubernetes. |
You're right, sorry--wasn't looking closely enough. |
@CecileRobertMichon @mboersma Will do, thanks for letting me know! |
Just opened kubernetes/org#3448! |
/verify-owners |
@mrbobbytables Hey so it looks like I'm still blocked on the owners issue. Do I need anything else besides the org request PR? |
/verify-owners |
hmm @Jont828 I don't see you in https://github.com/orgs/kubernetes/people?query=Jont828 despite your name being in https://github.com/kubernetes/org/blob/main/config/kubernetes/org.yaml#L619 Try opening an issue in the org repo to get help, those are supposed to be synced |
I opened an issue and accepted the org invite. Let's see if it works this time. |
yep I now see you in https://github.com/orgs/kubernetes/people?query=Jont828 /verify-owners |
Thanks everyone! |
Syncs up with https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/main/OWNERS_ALIASES
For some reason this failed the membership check in #3741, but Jonathan is indeed in the Kubernetes org. So let's try again.Pending membership in kubernetes/org#3448.cc: @Jont828 @CecileRobertMichon