Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jont828 as a CAPZ reviewer #3783

Merged
merged 1 commit into from
Jun 6, 2022

Conversation

mboersma
Copy link
Contributor

@mboersma mboersma commented May 27, 2022

Syncs up with https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/main/OWNERS_ALIASES

For some reason this failed the membership check in #3741, but Jonathan is indeed in the Kubernetes org. So let's try again. Pending membership in kubernetes/org#3448.

cc: @Jont828 @CecileRobertMichon

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 27, 2022
@k8s-ci-robot k8s-ci-robot added area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/k8s.gcr.io Code in k8s.gcr.io/ area/provider/azure Issues or PRs related to azure provider sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels May 27, 2022
@mboersma
Copy link
Contributor Author

Um...kubernetes/org#3156

Copy link
Contributor

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 27, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@CecileRobertMichon
Copy link
Member

@mboersma kubernetes/org#3156 added @Jont828 to kubernetes-sigs, not kubernetes. @Jont828 you need to open a separate issue in https://github.com/kubernetes/org to request that you kubernetes-sigs membership be transferred to kubernetes.

@mboersma
Copy link
Contributor Author

kubernetes/org#3156 added @Jont828 to kubernetes-sigs

You're right, sorry--wasn't looking closely enough.

@Jont828
Copy link
Contributor

Jont828 commented May 27, 2022

@CecileRobertMichon @mboersma Will do, thanks for letting me know!

@Jont828
Copy link
Contributor

Jont828 commented May 27, 2022

Just opened kubernetes/org#3448!

@mboersma
Copy link
Contributor Author

/verify-owners

@Jont828
Copy link
Contributor

Jont828 commented Jun 2, 2022

@mrbobbytables Hey so it looks like I'm still blocked on the owners issue. Do I need anything else besides the org request PR?

@CecileRobertMichon
Copy link
Member

/verify-owners

@CecileRobertMichon
Copy link
Member

hmm @Jont828 I don't see you in https://github.com/orgs/kubernetes/people?query=Jont828 despite your name being in https://github.com/kubernetes/org/blob/main/config/kubernetes/org.yaml#L619

Try opening an issue in the org repo to get help, those are supposed to be synced

@Jont828
Copy link
Contributor

Jont828 commented Jun 3, 2022

I opened an issue and accepted the org invite. Let's see if it works this time.

@CecileRobertMichon
Copy link
Member

yep I now see you in https://github.com/orgs/kubernetes/people?query=Jont828

/verify-owners

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jun 6, 2022
@k8s-ci-robot k8s-ci-robot merged commit 1e8b73c into kubernetes:main Jun 6, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 6, 2022
@mboersma mboersma deleted the sync-capz-maintainers-3 branch June 6, 2022 14:43
@Jont828
Copy link
Contributor

Jont828 commented Jun 15, 2022

Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/k8s.gcr.io Code in k8s.gcr.io/ area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants