Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cluster-api: add sbueringer to k8s-staging-cluster-api approvers #3415

Merged
merged 1 commit into from
Feb 18, 2022
Merged

cluster-api: add sbueringer to k8s-staging-cluster-api approvers #3415

merged 1 commit into from
Feb 18, 2022

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Feb 17, 2022 •
edited
Loading

Signed-off-by: Stefan Büringer [email protected]

Follow-up to: kubernetes-sigs/cluster-api#6109

/assign @fabriziopandini

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects labels Feb 17, 2022
@k8s-ci-robot k8s-ci-robot requested a review from detiber February 17, 2022 05:54
@k8s-ci-robot k8s-ci-robot added the area/k8s.gcr.io Code in k8s.gcr.io/ label Feb 17, 2022
@k8s-ci-robot k8s-ci-robot added the sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. label Feb 17, 2022
@k8s-ci-robot k8s-ci-robot added area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/groups Google Groups management, code in groups/ sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Feb 17, 2022
@sbueringer
Copy link
Member Author

sbueringer commented Feb 17, 2022 •
edited
Loading

/hold
waiting for feedback from Alberto

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 17, 2022
@sbueringer
Copy link
Member Author

/hold cancel

Should be ready for merge now

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 17, 2022
@fabriziopandini
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2022
@k8s-ci-robot k8s-ci-robot merged commit 93e74ae into kubernetes:main Feb 18, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Feb 18, 2022
@sbueringer sbueringer deleted the pr-capi-sbueringer branch February 18, 2022 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CecileRobertMichon CecileRobertMichon CecileRobertMichon left review comments

@enxebre enxebre enxebre left review comments

@detiber detiber Awaiting requested review from detiber

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

Assignees

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/groups Google Groups management, code in groups/ area/k8s.gcr.io Code in k8s.gcr.io/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.
5 participants
@sbueringer @fabriziopandini @k8s-ci-robot @enxebre @CecileRobertMichon