🌱 Promote sbueringer to Cluster API maintainer #6109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vince Prignano <[email protected]>
k8s-ci-robot
added
do-not-merge/hold
k8s-ci-robot
added
the
size/XS
|
/assign @CecileRobertMichon @fabriziopandini @enxebre |
vincepri
changed the title
|
YES!!! |
|
Super - Well - Deserved! |
|
+1000 |
sbueringer
reviewed
Feb 11, 2022
| @@ -22,6 +22,7 @@ aliases: | |||
| - CecileRobertMichon | |||
| - enxebre | |||
| - fabriziopandini | |||
| - sbueringer | |||
| - vincepri | |||
|
|
|||
| # folks who can review and LGTM any PRs in the repo | |||
There was a problem hiding this comment.
Nit: I think you want to drop l.31 too :)
|
huge +1!! 🙌 |
|
/lgtm Very well earned. |
k8s-ci-robot
added
the
lgtm
|
As per the 16th of February office hours discussion, |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Congrats!! |
This was referenced Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vince Prignano [email protected]
What this PR does / why we need it:
@sbueringer has been doing an incredible job in this project and would like to nominate for promotion as project maintainer.
/hold for consensus and community meeting
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #