Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infra/gcp: mv bash scripts to a dedicated folder #2632

Merged
merged 1 commit into from
Aug 30, 2021
Merged

infra/gcp: mv bash scripts to a dedicated folder #2632

merged 1 commit into from
Aug 30, 2021

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Aug 30, 2021 •
edited by spiffxp
Loading

Ref: #516

Move every bash script used for GCP operations to a separated folder.

Signed-off-by: Arnaud Meukam [email protected]

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 30, 2021
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/bash Bash scripts, testing them, writing less of them, code in infra/gcp/ area/infra Infrastructure management, infrastructure design, code in infra/ area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ sig/testing Categorizes an issue or PR as relevant to SIG Testing. wg/k8s-infra labels Aug 30, 2021
@ameukam
Copy link
Member Author

ameukam commented Aug 30, 2021

I ran

ensure-conformance-storage.sh
ensure-releng.sh

to ensure nothing is broken.

@k8s-ci-robot k8s-ci-robot added the area/audit Audit of project resources, audit followup issues, code in audit/ label Aug 30, 2021
@ameukam
Copy link
Member Author

ameukam commented Aug 30, 2021

cc @dims @spiffxp

@ameukam
infra/gcp: mv bash scripts to a dedicated folder
783277a 
Ref: kubernetes#516

Move every bash script used for GCP operations to a separated folder.

Signed-off-by: Arnaud Meukam <[email protected]>
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 30, 2021
@ameukam ameukam mentioned this pull request Aug 30, 2021
Merged
@spiffxp
Copy link
Member

spiffxp commented Aug 30, 2021

Hm, not sure I was quite ready to relocate all the bash to infra/gcp/bash... let me see what's outstanding

@spiffxp
Copy link
Member

spiffxp commented Aug 30, 2021

I don't see terraform modules relocated in this PR, I'm assuming that's coming (or I can do as followup)

@spiffxp spiffxp changed the title terraform: Fix modules path infra/gcp: mv bash scripts to a dedicated folder Aug 30, 2021
@spiffxp
Copy link
Member

spiffxp commented Aug 30, 2021

Ah this had some copy-pasta from #2630, this is actually just about moving the bash

@ameukam
Copy link
Member Author

ameukam commented Aug 30, 2021

I don't see terraform modules relocated in this PR, I'm assuming that's coming (or I can do as followup)

Sorry. made a mistake during a git rebase.

/retitle infra/gcp: mv bash scripts to a dedicated folder

@spiffxp
Copy link
Member

spiffxp commented Aug 30, 2021

I don't see anything major pending

I had a README I was working on for this dir, I'll adjust accordingly and open today/tomorrow

spiffxp
spiffxp approved these changes Aug 30, 2021
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0d2907e into kubernetes:main Aug 30, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Aug 30, 2021
@spiffxp spiffxp mentioned this pull request Aug 31, 2021
Merged
@spiffxp spiffxp mentioned this pull request Sep 10, 2021
Merged
@justaugustus justaugustus mentioned this pull request Oct 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp spiffxp approved these changes

@michelle192837 michelle192837 Awaiting requested review from michelle192837

@mpherman2 mpherman2 Awaiting requested review from mpherman2

Assignees

@spiffxp spiffxp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/audit Audit of project resources, audit followup issues, code in audit/ area/bash Bash scripts, testing them, writing less of them, code in infra/gcp/ area/infra Infrastructure management, infrastructure design, code in infra/ area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.
3 participants
@ameukam @spiffxp @k8s-ci-robot