Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terraform: Fix modules path #2630

Closed
wants to merge 1 commit into from
Closed

terraform: Fix modules path #2630

wants to merge 1 commit into from

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Aug 30, 2021

Modules path was not changed after Terraform resources relocation done
in : #2482.

Signed-off-by: Arnaud Meukam [email protected]

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 30, 2021
@ameukam
Copy link
Member Author

ameukam commented Aug 30, 2021

cc @dims @spiffxp

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/infra Infrastructure management, infrastructure design, code in infra/ area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters labels Aug 30, 2021
@k8s-ci-robot k8s-ci-robot added area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ sig/testing Categorizes an issue or PR as relevant to SIG Testing. wg/k8s-infra approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 30, 2021
spiffxp
spiffxp reviewed Aug 30, 2021
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase

@spiffxp spiffxp mentioned this pull request Aug 30, 2021
Merged
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 30, 2021
@ameukam ameukam force-pushed the tf-fix-module-path branch from 8c5c575 to f4b425d Compare August 30, 2021 21:43
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 30, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ameukam
terraform: Fix modules path
59ad77c 
Modules path was not changed after Terraform resources relocation done
in : kubernetes#2482.

Signed-off-by: Arnaud Meukam <[email protected]>
@ameukam ameukam force-pushed the tf-fix-module-path branch from f4b425d to 59ad77c Compare August 30, 2021 21:45
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 30, 2021
@ameukam
Copy link
Member Author

ameukam commented Aug 30, 2021

Needs rebase

Fixed in #2574.
/close

@k8s-ci-robot
Copy link
Contributor

@ameukam: Closed this PR.

In response to this:

Needs rebase

Fixed in #2574.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp spiffxp left review comments

@e-blackwelder e-blackwelder Awaiting requested review from e-blackwelder

@mpherman2 mpherman2 Awaiting requested review from mpherman2

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/infra Infrastructure management, infrastructure design, code in infra/ area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ameukam @k8s-ci-robot @spiffxp