Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move triage party under /apps #2303

Merged
merged 2 commits into from
Jul 9, 2021
Merged

Move triage party under /apps #2303

merged 2 commits into from
Jul 9, 2021

Conversation

jimdaga
Copy link

@jimdaga jimdaga commented Jul 8, 2021

Resolves:

Changes:

  • Move triage-party directory under the apps/triageparty-release path.
  • Move yaml out of the secondary release-team dir, into the root triageparty-release path.
  • Add the app: label on resources missing such label.
  • Add deploy.sh script, and update README with install steps

Notes:

  • Checked https://cs.k8s.io/ and didn't find any references to these files for automation use.
  • For now we will preserve the app: triage-party label until a final decision is made about standards.
  • The storage.yaml file used a slightly different app: label (app: triageparty without a -) that I'll be leaving in place until we finish the convo about naming.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 8, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @jimdaga. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. wg/k8s-infra labels Jul 8, 2021
@k8s-ci-robot k8s-ci-robot requested review from nikhita and thockin July 8, 2021 02:34
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 8, 2021
@jimdaga jimdaga marked this pull request as ready for review July 8, 2021 02:46
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 8, 2021
@jimdaga
Copy link
Author

jimdaga commented Jul 8, 2021

Note:
After #2290 is merged, we'll need to get the apps/README.md updated to reflect this app moved.

@cpanato
Copy link
Member

cpanato commented Jul 8, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 8, 2021
@cpanato
Copy link
Member

cpanato commented Jul 8, 2021

/assign @ameukam

Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 9, 2021
@ameukam
Copy link
Member

ameukam commented Jul 9, 2021

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, jimdaga, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e9633ef into kubernetes:main Jul 9, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jul 9, 2021
@spiffxp
Copy link
Member

spiffxp commented Jul 9, 2021

Had to edit deploy.sh to remove dry-run (I forgot to remove this when checking it in, will fix in followup PR shortly)

spiffxp@cloudshell:~/k8s.io/apps/triageparty-release (kubernetes-public)$ ./deploy.sh
managedcertificate.networking.gke.io/release-triage-k8s-io configured
configmap/triage-party-config-release configured
deployment.apps/triage-party configured
Warning: networking.k8s.io/v1beta1 Ingress is deprecated in v1.19+, unavailable in v1.22+; use networking.k8s.io/v1 Ingress
ingress.networking.k8s.io/triage-party-release unchanged
externalsecret.kubernetes-client.io/github-token created
service/triage-party-release configured
persistentvolumeclaim/triage-party-persistence unchanged

@spiffxp
Copy link
Member

spiffxp commented Jul 9, 2021

Followup PR: #2314

@jimdaga jimdaga deleted the issue-2150/move-triageparty-release branch July 9, 2021 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants