Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apps: mv kubernetes-external-secrets and node-perf-dash, update existing, add README #2290

Merged
merged 13 commits into from
Jul 8, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Jul 2, 2021

Part of umbrella issue #2150

I spiraled around the existing apps migrated (gcsweb, sippy) and moved over two more (kubernetes-exteral-secrets, node-perf-dash)

In sum, I tried to converge on and document a few conventions:

  • ensure apps/{app} matches the namespace declared in infra/gcp/namespaces/ensure-namespaces.sh
  • ensure apps/{app}/deploy.sh exists and is referenced in apps/{app}/README.md - I opted for a copy pasted script, see below
  • ensure apps/{app}/OWNERS has a sig/foo label in it
  • ensure apps/{app}/*.yaml k8s resources have appropriate labels: { app: {app} } stanzas
  • document these and other intended conventions in apps/README.md
  • add known issues to apps/README.md and warning that conventions are subject to change as we iterate
  • refresh /README.md to reference apps and link to Reorganize apps running on aaa under /apps #2150

The deploy.sh script:

  • The script is copy-pasted to make it clear we could likely reduce down to a single parameterized script
  • But I didn't reduce down yet, in case we find there are apps that don't fit this model and need to be customized as one-offs

A nice-to-have I did while I was here: sort the buckets used by gcsweb

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added wg/k8s-infra cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. wg/reliability Categorizes an issue or PR as relevant to WG Reliability approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 2, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Jul 2, 2021

/cc @ameukam @dims

@k8s-ci-robot k8s-ci-robot requested review from ameukam and dims July 2, 2021 20:10
@spiffxp
Copy link
Member Author

spiffxp commented Jul 2, 2021

/assign @thockin
for post-merge FYI

@ameukam
Copy link
Member

ameukam commented Jul 7, 2021

/lgtm
/hold
Remove hold when ready to deploy.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 7, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2021
- enforcement
- OWNER constraints enforcemed by humans
- no validation of yaml beyond yamllint
- `app:` convention enforcement by humands
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: spelling humands

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I'll fix this in a followup

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Followup PR: #2314

@spiffxp
Copy link
Member Author

spiffxp commented Jul 8, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2021
@k8s-ci-robot k8s-ci-robot merged commit 8c98d29 into kubernetes:main Jul 8, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jul 8, 2021
@spiffxp spiffxp deleted the move-more-apps branch July 8, 2021 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. wg/reliability Categorizes an issue or PR as relevant to WG Reliability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants