-
Notifications
You must be signed in to change notification settings - Fork 832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apps: mv kubernetes-external-secrets and node-perf-dash, update existing, add README #2290
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @thockin |
/lgtm |
- enforcement | ||
- OWNER constraints enforcemed by humans | ||
- no validation of yaml beyond yamllint | ||
- `app:` convention enforcement by humands |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: spelling humands
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, I'll fix this in a followup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Followup PR: #2314
/hold cancel |
Part of umbrella issue #2150
I spiraled around the existing apps migrated (gcsweb, sippy) and moved over two more (kubernetes-exteral-secrets, node-perf-dash)
In sum, I tried to converge on and document a few conventions:
apps/{app}
matches the namespace declared ininfra/gcp/namespaces/ensure-namespaces.sh
apps/{app}/deploy.sh
exists and is referenced inapps/{app}/README.md
- I opted for a copy pasted script, see belowapps/{app}/OWNERS
has asig/foo
label in itapps/{app}/*.yaml
k8s resources have appropriatelabels: { app: {app} }
stanzasapps/README.md
apps/README.md
and warning that conventions are subject to change as we iterate/README.md
to referenceapps
and link to Reorganize apps running on aaa under /apps #2150The
deploy.sh
script:A nice-to-have I did while I was here: sort the buckets used by gcsweb