Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade terraform provider for aaa Cluster #2008

Merged
merged 2 commits into from
May 6, 2021
Merged

Upgrade terraform provider for aaa Cluster #2008

merged 2 commits into from
May 6, 2021

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented May 6, 2021

Ref: #1403

First commit is needed because the terraform state got converted to 0.13 because of the deployment of #1974.
The second commit help migrate to the 3.x version of the terraform provider.

Signed-off-by: Arnaud Meukam [email protected]

ameukam added 2 commits May 5, 2021 22:48
@ameukam
Upgrade terraform provider
92cf2f5 
Upgrade terraform provider google to 3.1.0 from 2.14.

Upgrade terraform version to 0.13.6. We accidently convert the terraform
to a 0.13.x version when kubernetes#1974
was deployed.

Signed-off-by: Arnaud Meukam <[email protected]>
@ameukam
Hardcoded versions of terraform fields
65792ae 
Some fields or attributes of resources have changed in the version 3 of the
provider. This force the `aaa` cluster to be recreated.
We want to avoid this by setting static values of those fields.

Signed-off-by: Arnaud Meukam <[email protected]>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. wg/k8s-infra labels May 6, 2021
@k8s-ci-robot k8s-ci-robot requested review from dims and spiffxp May 6, 2021 01:43
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 6, 2021
@ameukam
Copy link
Member Author

ameukam commented May 6, 2021

/hold
/assign @spiffxp
/area infra/terraform

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ labels May 6, 2021
@ameukam
Copy link
Member Author

ameukam commented May 6, 2021

Changes expected are the removal of the region of the cluster and the node pools. : https://registry.terraform.io/providers/hashicorp/google/latest/docs/guides/version_3_upgrade#resource-google_container_cluster
https://registry.terraform.io/providers/hashicorp/google/latest/docs/guides/version_3_upgrade#resource-google_container_node_pool

        ]
        project             = "kubernetes-public"
      - region              = "us-central1" -> null
        version             = "1.17.17-gke.3000"

spiffxp
spiffxp approved these changes May 6, 2021
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

My bad on converting state, I thought we were ready for that independent of the provider

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ameukam
Copy link
Member Author

ameukam commented May 6, 2021

My bad on converting state, I thought we were ready for that independent of the provider

No problem. The version control mechanism is not rigorous enough. I'll improve it in a followup PR.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 6, 2021
@k8s-ci-robot k8s-ci-robot merged commit 9ebeabe into kubernetes:main May 6, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 6, 2021
@ameukam ameukam mentioned this pull request May 6, 2021
Merged
@spiffxp
Copy link
Member

spiffxp commented Jun 14, 2021

Upgrading terraform ref: #2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp spiffxp approved these changes

@dims dims Awaiting requested review from dims

Assignees

@spiffxp spiffxp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.
3 participants
@ameukam @k8s-ci-robot @spiffxp