Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get our terraform modules to the latest version of terraform #2020

Closed
spiffxp opened this issue May 7, 2021 · 5 comments
Closed

Get our terraform modules to the latest version of terraform #2020

spiffxp opened this issue May 7, 2021 · 5 comments
Assignees
Labels
area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/
Milestone

Comments

@spiffxp
Copy link
Member

spiffxp commented May 7, 2021

Mainly to avoid falling stale

There are features in terraform 0.14 that are interesting:

  • masking sensitive values from output (e.g. to allow for a terraform plan presubmit)
  • dependency lock files (so we could maybe stop having to bump the same version in 6 different files)

It's not yet clear to me whether there is anything super critical or interesting in 0.15, it mainly looks like the removal of deprecated things: https://www.terraform.io/upgrade-guides/0-15.html

/wg k8s-infra
/area terraform

@k8s-ci-robot
Copy link
Contributor

@spiffxp: The label(s) area/terraform cannot be applied, because the repository doesn't have them.

In response to this:

Mainly to avoid falling stale

There are features in terraform 0.14 that are interesting:

  • masking sensitive values from output (e.g. to allow for a terraform plan presubmit)
  • dependency lock files (so we could maybe stop having to bump the same version in 6 different files)

It's not yet clear to me whether there is anything super critical or interesting in 0.15, it mainly looks like the removal of deprecated things: https://www.terraform.io/upgrade-guides/0-15.html

/wg k8s-infra
/area terraform

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp spiffxp added the area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ label May 7, 2021
@spiffxp
Copy link
Member Author

spiffxp commented May 7, 2021

/milestone v1.22

@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 7, 2021
@spiffxp
Copy link
Member Author

spiffxp commented May 7, 2021

/assign @spiffxp @ameukam

@spiffxp
Copy link
Member Author

spiffxp commented Aug 4, 2021

/close
We're up to terraform 1.0 and I think that's good enough to call this done.

Auto-bumping our terraform would be the next logical step, however we need to get better testing and validation in place before forcing that churn upon us IMO

@k8s-ci-robot
Copy link
Contributor

@spiffxp: Closing this issue.

In response to this:

/close
We're up to terraform 1.0 and I think that's good enough to call this done.

Auto-bumping our terraform would be the next logical step, however we need to get better testing and validation in place before forcing that churn upon us IMO

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/
Projects
None yet
Development

No branches or pull requests

3 participants