audit as of 2020-02-17 #1676
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -72,6 +72,7 @@ | |
| "group:[email protected]", | ||
| "user:[email protected]", | ||
| "user:[email protected]", | ||
| "user:[email protected]", | ||
| "user:[email protected]", | ||
| "user:[email protected]", | ||
| "user:[email protected]" | ||
|
|
@@ -96,6 +97,12 @@ | |
| ], | ||
| "role": "roles/resourcemanager.projectDeleter" | ||
| }, | ||
| { | ||
| "members": [ | ||
| "group:[email protected]" | ||
| ], | ||
| "role": "roles/secretmanager.viewer" | ||
| }, | ||
| { | ||
| "members": [ | ||
| "group:[email protected]" | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| Bucket Policy Only setting for gs://k8s-conform-provider-openstack: | ||
| Enabled: True | ||
| LockedTime: 2021-05-16 15:12:16.571000+00:00 | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| gs://k8s-conform-provider-openstack/ has no CORS configuration. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| { | ||
| "bindings": [ | ||
| { | ||
| "members": [ | ||
| "group:[email protected]", | ||
| "projectEditor:k8s-conform", | ||
| "projectOwner:k8s-conform" | ||
| ], | ||
| "role": "roles/storage.legacyBucketOwner" | ||
| }, | ||
| { | ||
| "members": [ | ||
| "projectViewer:k8s-conform" | ||
| ], | ||
| "role": "roles/storage.legacyBucketReader" | ||
| }, | ||
| { | ||
| "members": [ | ||
| "group:[email protected]", | ||
| "serviceAccount:[email protected]" | ||
| ], | ||
| "role": "roles/storage.legacyBucketWriter" | ||
| }, | ||
| { | ||
| "members": [ | ||
| "group:[email protected]", | ||
| "group:[email protected]", | ||
| "serviceAccount:[email protected]" | ||
| ], | ||
| "role": "roles/storage.objectAdmin" | ||
| }, | ||
| { | ||
| "members": [ | ||
| "allUsers" | ||
| ], | ||
| "role": "roles/storage.objectViewer" | ||
| } | ||
| ] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| gs://k8s-conform-provider-openstack/ has no logging configuration. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "createTime": "2021-02-15T15:18:08.840992Z", | ||
| "name": "projects/228988630781/secrets/service-provider-openstack-key", | ||
| "replication": { | ||
| "automatic": {} | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,7 +2,7 @@ | |
| "bindings": [ | ||
| { | ||
| "members": [ | ||
| "group:[email protected]" | ||
| ], | ||
| "role": "roles/secretmanager.secretAccessor" | ||
| } | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| [ | ||
| { | ||
| "createTime": "2021-02-15T15:18:09.874889Z", | ||
| "name": "projects/228988630781/secrets/service-provider-openstack-key/versions/1", | ||
| "replicationStatus": { | ||
| "automatic": {} | ||
| }, | ||
| "state": "ENABLED" | ||
| } | ||
| ] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| { | ||
| "displayName": "service-provider-openstack", | ||
| "email": "[email protected]", | ||
| "name": "projects/k8s-conform/serviceAccounts/[email protected]", | ||
| "oauth2ClientId": "114482259319052246948", | ||
| "projectId": "k8s-conform", | ||
| "uniqueId": "114482259319052246948" | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| {} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,6 +12,12 @@ | |
| ], | ||
| "role": "roles/compute.serviceAgent" | ||
| }, | ||
| { | ||
| "members": [ | ||
| "serviceAccount:[email protected]" | ||
| ], | ||
| "role": "roles/containerregistry.ServiceAgent" | ||
| }, | ||
| { | ||
| "members": [ | ||
| "serviceAccount:[email protected]", | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,9 @@ | ||
| NAME TITLE | ||
| compute.googleapis.com Compute Engine API | ||
| containerregistry.googleapis.com Container Registry API | ||
|
There was a problem hiding this comment. Is this scripted? Who will ultimately clean these up? There was a problem hiding this comment. how to cleanup will be followed up in #1675 Yes this is scripted: https://github.com/kubernetes/k8s.io/blob/main/infra/gcp/prow/ensure-e2e-projects.sh This was added via #1536 |
||
| logging.googleapis.com Cloud Logging API | ||
| monitoring.googleapis.com Cloud Monitoring API | ||
| oslogin.googleapis.com Cloud OS Login API | ||
| pubsub.googleapis.com Cloud Pub/Sub API | ||
| storage-api.googleapis.com Google Cloud Storage JSON API | ||
| storage-component.googleapis.com Cloud Storage | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,6 +12,12 @@ | |
| ], | ||
| "role": "roles/compute.serviceAgent" | ||
| }, | ||
| { | ||
| "members": [ | ||
| "serviceAccount:[email protected]" | ||
| ], | ||
| "role": "roles/containerregistry.ServiceAgent" | ||
| }, | ||
| { | ||
| "members": [ | ||
| "serviceAccount:[email protected]", | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,9 @@ | ||
| NAME TITLE | ||
| compute.googleapis.com Compute Engine API | ||
| containerregistry.googleapis.com Container Registry API | ||
| logging.googleapis.com Cloud Logging API | ||
| monitoring.googleapis.com Cloud Monitoring API | ||
| oslogin.googleapis.com Cloud OS Login API | ||
| pubsub.googleapis.com Cloud Pub/Sub API | ||
| storage-api.googleapis.com Google Cloud Storage JSON API | ||
| storage-component.googleapis.com Cloud Storage |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,6 +12,12 @@ | |
| ], | ||
| "role": "roles/compute.serviceAgent" | ||
| }, | ||
| { | ||
| "members": [ | ||
| "serviceAccount:[email protected]" | ||
| ], | ||
| "role": "roles/containerregistry.ServiceAgent" | ||
| }, | ||
| { | ||
| "members": [ | ||
| "serviceAccount:[email protected]", | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see no trace of this in the codebase? Why does it exist?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dims 2/15/21
Explain?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like we have a bunch of these. i only run scripts, i don't know enough to meddle in the UI :) I believe i was re-running some of the conform buckets
In this instance i think i was trying to re-run scripts again to see how to help with:
kubernetes/test-infra#20914
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/kubernetes/k8s.io/pull/1676/files/5552daee41483e00b09c7ad5b1c57d699ab9848d..176f6e37790b71ce30ef9b57ddf78804abdfe1b3#r585516339
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ultimately I would like for us to have this enabled across the org, and enforced via an org policy
per-object ACLs are much trickier to audit and enforce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, my point in tagging @dims was that I can't find any trace of these projects in git. Did someone forget to send a PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i know we cleaned some stuff up in:
#1311 (comment)
Only reference to
k8s-conform-provider-openstacki can find is:theopenlab/openlab#691
may be @chrigl knows more?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thockin it is in the codebase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I apologize. I got bitten by master/main - I had not resynced this copy in a while and was trying to sync master and not noticing that it failed.
Indeed, it is in the tree. Mea culpa, my apologies.