Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate away from google.com gcp project k8s-federated-conformance #1311

Closed
spiffxp opened this issue Oct 6, 2020 · 23 comments
Closed

Migrate away from google.com gcp project k8s-federated-conformance #1311

spiffxp opened this issue Oct 6, 2020 · 23 comments
Assignees
Labels
priority/backlog Higher priority than priority/awaiting-more-evidence. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Milestone

Comments

@spiffxp
Copy link
Member

spiffxp commented Oct 6, 2020

Part of umbrella issue to migrate away from google.com gcp projects: #1469

Umbrella issue for migrating or removing dependence on all of the kubernetes project infra that lives under k8s-federated-conformance. For each of these buckets there may also exist corresponding service accounts.

  • gs://k8s-conformance/
  • gs://k8s-conformance-alibaba/
  • gs://k8s-conformance-arm/
  • gs://k8s-conformance-baiducloud/
  • gs://k8s-conformance-demo/
  • gs://k8s-conformance-digitalocean/
  • gs://k8s-conformance-kind-arm64-openlab/
  • gs://k8s-conformance-openstack/
  • gs://k8s-conformance-oracle-cloud/

Of note: we have a system already in place to support this (ref: https://github.com/kubernetes/k8s.io/blob/master/infra/gcp/ensure-conformance-storage.sh), so this is mostly a matter of contacting and pushing migration along

@spiffxp spiffxp added sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/testing Categorizes an issue or PR as relevant to SIG Testing. wg/k8s-infra labels Oct 6, 2020
@spiffxp spiffxp added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Jan 22, 2021
@BenTheElder
Copy link
Member

BenTheElder commented Feb 12, 2021

I audited each of these by checking the contact info I have listed on the associated service account keys and gsutil ls -l gs://${BUCKET}/** | sort -k 2 to inspect timestamps + keys of uploaded entries.

  • gs://k8s-conformance: delete
    • This one is literally empty, nothing to do, we can just delete it.
    • There's no contact / account for this, I created this and migrated initial uploaders to individual buckets. Anything in it aged out.
  • gs://k8s-conformance-alibaba: delete
    • 2020-10-14T13:47:10Z is the most recent entry. I do not believe this is being used for CI results currently, and we did not offer this bucket for any other purpose.
    • They can reapply for a wg-k8s-infra bucket with the updated instructions if they wish to publish continuous conformance results in the future
    • We can delete this.
    • Contact is @aoxn -- FYI this is not the intended use of this, if you're interested in running results against Kubernetes at HEAD and submitting them please re-apply through the new instructions for this repo.
  • gs://k8s-conformance-arm: migrate delete
    • This one is active, as of 2021-02-12T21:22:47Z
    • @lubinsz is the contact for this one
    • We should help migrate this one.
    • Lack of response, ultimately deleted
  • gs://k8s-conformance-baiducloud: delete
    • Same story as conformance-alibaba, this isn't running continuous results for Kubernetes, it's just some sporadic uploads at old versions (newest is 1.13 in march last year). That's not the purpose of this program, they should be submitting to the CNCF conformance results instead
    • We can delete this.
  • gs://k8s-conformance-demo: delete
    • This was provided to @andrewsykim when circulating the concept to SIG cloud provider, to show how this works and how easy it can be. This serves no purpose now.
    • We can delete this.
  • gs://k8s-conformance-digitalocean: delete
    • This was last updated 2018-10-08T16:46:32Z. It was only uploaded a few times 2018-09 onwards.|
    • @andrewsykim was the contact but has since changed employers, however it's unused anyhow.
    • We can delete this.
  • gs://k8s-conformance-kind-arm64-openlab: delete
    • @dims and Melvin Hillsman (I have email but not github handy) are contacts on this one
    • Last uploaded 2020-05-1308:42:58Z. Did upload for some time but has been inactive since then
    • We can delete this, if they're interested in fixing the infra they can apply for a new bucket/key.
  • gs://k8s-conformance-openstack: migrate
    • @dims is again the listed contact
    • This one is quite active, last result 2021-02-12T17:36:21Z and it even has junit_runner.xml etc, and against k8s 1.20
    • We should help migrate this one.
  • gs://k8s-conformance-oracle-cloud: delete
    • I have contact emails but not GitHub
    • This was last updated 2020-03-11T11:27:56Z, the highest version I see is 1.15.
    • Does not appear to be in current use for nearly a year ... they can reapply.
    • We can delete this.

@BenTheElder
Copy link
Member

I have taken no action yet, but proposed action and detailed reasoning per bucket is above. TLDR:

@dims
Copy link
Member

dims commented Feb 12, 2021

@BenTheElder both buckets have the same name? (or a typo)

Either way, +1 to removing the one that lists Melvin as well.

@BenTheElder
Copy link
Member

BenTheElder commented Feb 12, 2021

fixed! yep they are in the same order as @spiffxp's opening comment, bad re-formatting -- the first bucket should have read k8s-conformance-kind-arm64-openlab which is inactive.

@chrigl
Copy link

chrigl commented Feb 14, 2021

@BenTheElder I will take care of migrating gs://k8s-conformance-openstack

@BenTheElder
Copy link
Member

Thank you!!

wangxiyuan pushed a commit to theopenlab/openlab-zuul-jobs that referenced this issue Feb 18, 2021
We must replace our old bucket for test results by a new one. In this
PR, I added the new one additionally to the old one. When the new one
works as expected, I will remove the old one.

See: kubernetes/k8s.io#1311
@spiffxp
Copy link
Member Author

spiffxp commented Feb 19, 2021

I have taken no action yet, but proposed action and detailed reasoning per bucket is above

/assign @BenTheElder
this plan LGTM, I'm gonna put in our current milestone

/milestone v1.21

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 19, 2021
@BenTheElder
Copy link
Member

Taking action on the unused buckets, will update the checklist.

@BenTheElder
Copy link
Member

We are down to the two marked to migrate, and it appears @chrigl already migrated openstack (Thank you!), leaving that one alone until this is confirmed though 🙂

@chrigl
Copy link

chrigl commented Feb 25, 2021

@BenTheElder At least from test runs, there should no new content go into gs://k8s-conformance-openstack

@spiffxp
Copy link
Member Author

spiffxp commented Apr 15, 2021

/milestone v1.22

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.21, v1.22 Apr 15, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Jun 17, 2021

/assign @chrigl
Keeping track of who's helped close this out

@BenTheElder
Copy link
Member

Small update: deleting the old k8s-conformance-openstack bucket and creds now.

I think we need to set a responsiveness deadline for the remaining bucket. pinging again @lubinsz

Worst case I don't think it's a big deal if we lose older results from an unresponsive bucket and a new bucket can be easily requested.

@BenTheElder
Copy link
Member

Only gs://k8s-conformance-arm + matching service account key remains. All other buckets have been migrated or otherwise cleaned up.

@BenTheElder
Copy link
Member

Spoke to @spiffxp, setting a deadline of 4 weeks and reaching out today by:

  • github
  • slack
  • email

After 4 weeks (people could be on vacation right now, and this is not maximally urgent) we will soft delete by revoking the service account permissions.
I'll ping again then and after say another week actually delete the bucket, to be replaced by a new request to this project.

@BenTheElder
Copy link
Member

The 4 weeks deadline has more than elapsed, it has been 6 weeks.

Time to soft-revoke permissions.

@BenTheElder
Copy link
Member

Last upload is 2021-05-14 as-is.

@BenTheElder
Copy link
Member

I have deleted "Storage Object Creator" from the associated service account for gs://k8s-conformance-arm.

@spiffxp
Copy link
Member Author

spiffxp commented Aug 4, 2021

/milestone v1.23

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.22, v1.23 Aug 4, 2021
@BenTheElder
Copy link
Member

We'll just miss it, tomorrow I intend to delete the remaining bucket and close this out. It'll have been a week without the ability to write to the bucket.

@BenTheElder
Copy link
Member

Bucket is deleting.

@BenTheElder
Copy link
Member

This is done.
/close

@k8s-ci-robot
Copy link
Contributor

@BenTheElder: Closing this issue.

In response to this:

This is done.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/backlog Higher priority than priority/awaiting-more-evidence. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Development

No branches or pull requests

5 participants