Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multi-arch images #4271

Merged
merged 1 commit into from
Apr 28, 2020
Merged

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jul 3, 2019

What this PR does / why we need it:

This allows users to just pull the image quay.io/kubernetes-ingress-controller/nginx-ingress-controller:X.XX.X independently of the arch (amd64, arm or arm64)

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 3, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2019
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 17, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 25, 2019
@codecov-io
Copy link

codecov-io commented Aug 25, 2019

Codecov Report

Merging #4271 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4271      +/-   ##
==========================================
+ Coverage   58.37%   58.39%   +0.01%     
==========================================
  Files          88       88              
  Lines        6720     6720              
==========================================
+ Hits         3923     3924       +1     
+ Misses       2369     2367       -2     
- Partials      428      429       +1
Impacted Files Coverage Δ
internal/watch/file_watcher.go 84.61% <0%> (+3.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aba58d6...3d40fa0. Read the comment docs.

@aledbf
Copy link
Member Author

aledbf commented Sep 18, 2019

/retest

@billimek
Copy link

Multi-arch support would be great. Is there anything preventing this PR from moving forward?

@aledbf
Copy link
Member Author

aledbf commented Oct 29, 2019

Multi-arch support would be great. Is there anything preventing this PR from moving forward?

Support in quay.io. In theory, this feature will be available before the end of the year.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 25, 2020

@aledbf: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-ingress-nginx-chart-lint 3d40fa0389af8e2613ca2eb4c65d8b5884bdf19f link /test pull-ingress-nginx-chart-lint

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 25, 2020
@rmb938
Copy link

rmb938 commented Apr 6, 2020

@aledbf quay.io now supports this feature. prometheus has been using it for a while.

@aledbf
Copy link
Member Author

aledbf commented Apr 6, 2020

@rmb938 this is not enabled for all the repositories in quay.io.
(I have a support ticket still open, waiting for support)

@rmb938
Copy link

rmb938 commented Apr 6, 2020

Oh ok I didn't realize that.

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 28, 2020
@aledbf aledbf changed the title WIP: Add support for multi-arch images Add support for multi-arch images Apr 28, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 28, 2020
@aledbf
Copy link
Member Author

aledbf commented Apr 28, 2020

/hold cancel

@aledbf
Copy link
Member Author

aledbf commented Apr 28, 2020

It seems this is working now. The next release will use a multi-arch images

@aledbf aledbf merged commit 5d011db into kubernetes:master Apr 28, 2020
@aledbf aledbf deleted the multi-arch branch April 28, 2020 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants