-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for multi-arch images #4271
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #4271 +/- ##
==========================================
+ Coverage 58.37% 58.39% +0.01%
==========================================
Files 88 88
Lines 6720 6720
==========================================
+ Hits 3923 3924 +1
+ Misses 2369 2367 -2
- Partials 428 429 +1
Continue to review full report at Codecov.
|
/retest |
Multi-arch support would be great. Is there anything preventing this PR from moving forward? |
Support in quay.io. In theory, this feature will be available before the end of the year. |
@aledbf: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@aledbf quay.io now supports this feature. prometheus has been using it for a while. |
@rmb938 this is not enabled for all the repositories in quay.io. |
Oh ok I didn't realize that. |
/hold cancel |
It seems this is working now. The next release will use a multi-arch images |
What this PR does / why we need it:
This allows users to just pull the image
quay.io/kubernetes-ingress-controller/nginx-ingress-controller:X.XX.X
independently of the arch (amd64, arm or arm64)Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: