-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix scripts to be able to run tests in docker #4299
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4299 +/- ##
==========================================
+ Coverage 58.3% 58.33% +0.03%
==========================================
Files 87 87
Lines 6478 6478
==========================================
+ Hits 3777 3779 +2
+ Misses 2274 2273 -1
+ Partials 427 426 -1
Continue to review full report at Codecov.
|
@aledbf is this ready for review? Test failures are legit? |
056e83a
to
3c15963
Compare
/retest |
/test pull-ingress-nginx-test |
@ElvinEfendi ready for review |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, ElvinEfendi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
./build/run-in-docker.sh make test
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #4297Special notes for your reviewer: