Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect .DisableLua access. #3144

Merged
merged 2 commits into from
Sep 26, 2018

Conversation

Globegitter
Copy link
Contributor

What this PR does / why we need it: This fixes an error in the previously just PR #3143

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 26, 2018
@Globegitter
Copy link
Contributor Author

@aledbf Just noticed that when I tried out the dev image.

@aledbf
Copy link
Member

aledbf commented Sep 26, 2018

We really need e2e tests for custom errors

@codecov-io
Copy link

Codecov Report

Merging #3144 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3144   +/-   ##
=======================================
  Coverage   47.66%   47.66%           
=======================================
  Files          77       77           
  Lines        5708     5708           
=======================================
  Hits         2721     2721           
  Misses       2632     2632           
  Partials      355      355

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7c2633...b610919. Read the comment docs.

@aledbf
Copy link
Member

aledbf commented Sep 26, 2018

@Globegitter please change the code to something like

{{ $isLuaDisabled := .DisableLua }}

before the range and then use $isLuaDisabled in the if

@Globegitter
Copy link
Contributor Author

@aledbf Done.

@aledbf
Copy link
Member

aledbf commented Sep 26, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 26, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, Globegitter

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2018
@aledbf aledbf merged commit bf4be49 into kubernetes:master Sep 26, 2018
@aledbf
Copy link
Member

aledbf commented Sep 26, 2018

@Globegitter dev image is updated

@Globegitter Globegitter deleted the mp-disable-lua-fix branch September 26, 2018 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants