-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect .DisableLua access. #3144
Conversation
@aledbf Just noticed that when I tried out the dev image. |
We really need e2e tests for custom errors |
Codecov Report
@@ Coverage Diff @@
## master #3144 +/- ##
=======================================
Coverage 47.66% 47.66%
=======================================
Files 77 77
Lines 5708 5708
=======================================
Hits 2721 2721
Misses 2632 2632
Partials 355 355 Continue to review full report at Codecov.
|
@Globegitter please change the code to something like
before the range and then use |
@aledbf Done. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, Globegitter The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Globegitter dev image is updated |
What this PR does / why we need it: This fixes an error in the previously just PR #3143
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: